Skip to content

Conversation

@jonasnick
Copy link
Contributor

No description provided.

@instagibbs
Copy link
Contributor

This results in an order of magnitude speedup on checking the pegin transactions, according to @jonasnick .

@instagibbs
Copy link
Contributor

Pretty sure the getblockhash check is completely redundant as well. We now do a startup check to ensure we're querying the right bitcoind instance.

@jonasnick jonasnick changed the title Use getblockheader instead of getblock when checking if block is in the main chain Speed up peg-in validation Sep 11, 2017
@instagibbs
Copy link
Contributor

utACK 25c8a49

@jtimon
Copy link
Contributor

jtimon commented Sep 12, 2017

Mhmm, it seems it genesishash was passed but never used?
utACK 25c8a49

@instagibbs
Copy link
Contributor

@jtimon was used to check the result of the first call, but it's duplication of effort as we do this check on init.

@instagibbs instagibbs merged commit 25c8a49 into ElementsProject:elements-0.14.1 Sep 13, 2017
instagibbs added a commit that referenced this pull request Sep 13, 2017
25c8a49 Remove unnecessary genesis hash check in IsConfirmedBitcoinBlock (Jonas Nick)
42b6330 Use getblockheader instead of getblock when checking if block is in the main chain (Jonas Nick)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants