-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getnewaddress - don't blind bech32 addresses #1246
Conversation
059a4a6 looks fine to me. Locally the following tests fail
These look like real failures; they happen consistently. |
Thanks @apoelstra - fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 49c3ea3
Now I'm a bit concerned that this change will break existing workflows of people by unblinding their addresses on thm. |
It may, but I think the old behavior was probably wrong. Not sure how best to handle this. |
I think the old behavior was at least inconsistent, so I'm fine with a comment added to the release notes and this fix making things consistent |
fixes #1245 -
getnewaddress
will now return an unblinded bech32 address even when-blindedaddresses=1
in config