Skip to content

Group imports: std, external, crate#165

Merged
jayvdb merged 2 commits intoElectron100:masterfrom
jayvdb:group-imports
Nov 16, 2023
Merged

Group imports: std, external, crate#165
jayvdb merged 2 commits intoElectron100:masterfrom
jayvdb:group-imports

Conversation

@jayvdb
Copy link
Copy Markdown
Collaborator

@jayvdb jayvdb commented Nov 13, 2023

Repeat of #141

Also remove

  • use of self::... because it requires possibly newbies to grok an extra unnecessary & less common piece of Rust syntax.
  • use of use ..::* in non-test/non-example code, with the exception of butane::db reexporting all of butane_core::db. As shown in this PR, such use can hide important std::* imports.

@jayvdb jayvdb merged commit a926428 into Electron100:master Nov 16, 2023
@jayvdb jayvdb deleted the group-imports branch November 16, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants