Remove ObjectState (breaking change)#151
Merged
Electron100 merged 12 commits intomasterfrom Nov 1, 2023
Merged
Conversation
Closed
jayvdb
reviewed
Oct 23, 2023
jayvdb
reviewed
Oct 24, 2023
jayvdb
reviewed
Oct 24, 2023
jayvdb
reviewed
Oct 24, 2023
jayvdb
reviewed
Oct 25, 2023
jayvdb
reviewed
Oct 25, 2023
Merged
jayvdb
reviewed
Oct 25, 2023
jayvdb
reviewed
Oct 25, 2023
jayvdb
reviewed
Oct 25, 2023
jayvdb
reviewed
Oct 25, 2023
Electron100
pushed a commit
that referenced
this pull request
Oct 30, 2023
Add docs to pub members that deepsource is complaining about at #151
jayvdb
reviewed
Oct 30, 2023
jayvdb
reviewed
Oct 30, 2023
jayvdb
reviewed
Oct 30, 2023
jayvdb
approved these changes
Oct 30, 2023
Collaborator
jayvdb
left a comment
jayvdb
left a comment
There was a problem hiding this comment.
a few comments added, but overall this is awesome and lets get it in asap
Electron100
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectState never really took on as large a role I had originally envisioned, while at the same time being quite clunky -- an extra field automatically injected into all model types. It had a single member
saved, which tracks whether the object had previously been saved or not. Most of the time this doesn't matter though, especially since #117 changed save to upsert. I believe the only remaining case where it does matter is for automatic creation of primary keys, and those were operating in a semantic grey area where creating an unitialized primary key required setting it to-1or similar.This change does the following
ObjectStateand the auto-createdstatemember for each modelAutoPk<T>type which is used as the type for fields which represent automatic primary keys. This tracks whether the primary key has already been generated or not.