UPSTREAM: <carry>: chore(backend): Rename UpdateLastRun -> SetLastRun…

…Timestamp follup up to bf77909. Rename UpdateLastRun -> SetLastRunTimestamp also tweak a related log message Signed-off-by: Greg Sheremeta <[email protected]>
ElayAharoni · Sep 3, 2024 · 8e7a0a4 · 8e7a0a4
1 parent 9686eaf
commit 8e7a0a4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/backend/src/apiserver/resource/resource_manager.go b/backend/src/apiserver/resource/resource_manager.go
@@ -566,9 +566,9 @@ func (r *ResourceManager) CreateRun(ctx context.Context, run *model.Run) (*model
 	}
 
 	// Upon run creation, update owning experiment
-	err = r.experimentStore.UpdateLastRun(newRun)
+	err = r.experimentStore.SetLastRunTimestamp(newRun)
 	if err != nil {
-		return nil, util.Wrap(err, fmt.Sprintf("Failed to update last_run_created_at in experiment %s for run %s", newRun.ExperimentId, newRun.UUID))
+		return nil, util.Wrap(err, fmt.Sprintf("Failed to set last run timestamp on experiment %s for run %s", newRun.ExperimentId, newRun.UUID))
 	}
 
 	return newRun, nil
@@ -1253,7 +1253,7 @@ func (r *ResourceManager) ReportWorkflowResource(ctx context.Context, execSpec u
 			runId = run.UUID
 		}
 		// Upon run creation, update owning experiment
-		if updateError = r.experimentStore.UpdateLastRun(run); updateError != nil {
+		if updateError = r.experimentStore.SetLastRunTimestamp(run); updateError != nil {
 			return nil, util.Wrapf(updateError, "Failed to report a workflow for existing run %s during updating the owning experiment.", runId)
 		}
 	}

diff --git a/backend/src/apiserver/storage/experiment_store.go b/backend/src/apiserver/storage/experiment_store.go
@@ -33,7 +33,7 @@ type ExperimentStoreInterface interface {
 	ArchiveExperiment(expId string) error
 	UnarchiveExperiment(expId string) error
 	DeleteExperiment(uuid string) error
-	UpdateLastRun(run *model.Run) error
+	SetLastRunTimestamp(run *model.Run) error
 }
 
 type ExperimentStore struct {
@@ -419,9 +419,9 @@ func (s *ExperimentStore) UnarchiveExperiment(expId string) error {
 	return nil
 }
 
-func (s *ExperimentStore) UpdateLastRun(run *model.Run) error {
+func (s *ExperimentStore) SetLastRunTimestamp(run *model.Run) error {
 	expId := run.ExperimentId
-	// UpdateLastRun results in the experiment getting last_run_created_at updated
+	// SetLastRunTimestamp results in the experiment getting last_run_created_at updated
 	query, args, err := sq.
 		Update("experiments").
 		SetMap(sq.Eq{

diff --git a/frontend/src/pages/__snapshots__/ExperimentList.test.tsx.snap b/frontend/src/pages/__snapshots__/ExperimentList.test.tsx.snap
@@ -21,6 +21,7 @@ exports[`ExperimentList renders a list of one experiment 1`] = `
           "customRenderer": [Function],
           "flex": 1,
           "label": "Last 5 runs",
+          "sortKey": "last_run_created_at",
         },
       ]
     }
@@ -70,6 +71,7 @@ exports[`ExperimentList renders a list of one experiment with error 1`] = `
           "customRenderer": [Function],
           "flex": 1,
           "label": "Last 5 runs",
+          "sortKey": "last_run_created_at",
         },
       ]
     }
@@ -106,6 +108,7 @@ exports[`ExperimentList renders a list of one experiment with no description 1`]
           "customRenderer": [Function],
           "flex": 1,
           "label": "Last 5 runs",
+          "sortKey": "last_run_created_at",
         },
       ]
     }
@@ -142,6 +145,7 @@ exports[`ExperimentList renders an empty list with empty state message 1`] = `
           "customRenderer": [Function],
           "flex": 1,
           "label": "Last 5 runs",
+          "sortKey": "last_run_created_at",
         },
       ]
     }