Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gracefully close connection fixes #21

Conversation

tebruno99
Copy link

@tebruno99 tebruno99 commented Dec 13, 2022

Original PR: gorilla#487 by @sanketplus

Fixes: gorilla#448 #20

Creating PR to request and accommodate comments. There are multiple areas which requires decision making.>

whether to maintain backwards compatibility with variadic args, or is there a better approach.
after sending a close frame, what to do exactly. Wait for sometime and give up? How long to wait?
Do we need to set kind of read lock for public read methods once close has been initiated?
How exactly do I interpret output of wstest?
<- suggestions

@tebruno99 tebruno99 linked an issue Dec 13, 2022 that may be closed by this pull request
@tebruno99 tebruno99 changed the title gracefully close connection fixes gracefully close connection fixes #20 Dec 13, 2022
@tebruno99 tebruno99 changed the title gracefully close connection fixes #20 gracefully close connection fixes Dec 13, 2022
@tebruno99 tebruno99 merged commit 0e93d8b into ElasticPerch:enhancement/20-add-higher-level-api-to-gracefully-close-connection Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants