Replace perf with faster patched built-from-source version #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replaces the
perf
installation with a built-from-source version that's patched to be much, much faster. This will make it much easier to analyze and compare the performance of different versions. After this patch, the flamegraph takes about 8 minutes to be generated on anIntel(R) Core(TM) i7-10750H CPU @ 2.60GHz
.The patched version is the one described in here.
Type of change
💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.Additional comments
While I could have opted for not installing
linux-tools-generic
in the first place, instead of installing and the removing before patching, I decided to execute the process from the same starting point used in the instructions in flamegraph-rs/flamegraph#74 (comment) , which assumelinux-tools-generic
(and the packages it depends on) to have been previously installed.Reference results
The performance results for both the
likelihood
andbeam
configurations can be seen below.In all cases, the results were obtained by profiling e72e148 with the step-by-step instructions from
PROFILING.md
.The computer is an
Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
.Beam sensor model
Likelihood sensor model