Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: sd rescan and load on triple click #47

Closed
wants to merge 1 commit into from
Closed

bugfix: sd rescan and load on triple click #47

wants to merge 1 commit into from

Conversation

tsctrl
Copy link

@tsctrl tsctrl commented May 15, 2022

file.path() not working on platform = espressif32

@tsctrl tsctrl mentioned this pull request May 15, 2022
@Edzelf
Copy link
Owner

Edzelf commented May 15, 2022

Latest version allows platform = espressif32 as well as "[email protected]".

@tsctrl
Copy link
Author

tsctrl commented May 15, 2022

@Edzelf
changes to get full path is added on arduino version 2.0 or pio v4.0.0 only. old file.name() to get full path will not work anymore

minimum version is v4.0.0
https://github.com/platformio/platform-espressif32/releases/tag/v4.0.0

arduino version 2.0.3 was release few week ago, definitely more stable and less time to figure problem. and still under espressif support. i would suggest radio v2 to be updated to the latest arduino 2.0.3 version to allow esp32 s3 support for new design as esp32 v1 already very old. there is no changes required on the esp radio end. this for hope to support the future existence on this beloved internet radio apps. 👯‍♂️

@tsctrl
Copy link
Author

tsctrl commented May 15, 2022

Hi @Edzelf

for this recent change:
#ifdef DEC_HELIX_INT
#if ESP_ARDUINO_VERSION_MAJOR >= 2
#error Internal DAC will not work in this version of the platform. Use [email protected].
#endif
#endif

i did not try but internal dac should work on arduino 2.0.3 as mentioned here:
espressif/arduino-esp32#5938

@tsctrl
Copy link
Author

tsctrl commented May 15, 2022

closing this, as per solution added. thanks @Edzelf

@tsctrl tsctrl closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants