Skip to content

fix minor issue with regard to randomized_svd() #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

schnell3526
Copy link
Contributor

this pr is related to this issue(#94)

Thank you for developing such a useful tool!

Fixed a minor bug that I reported in an issue(#94).
If you would like to keep the same behavior as before, but remove the warning, this commit will fix it.

If you have time, please check it out.

reference) https://scikit-learn.org/stable/modules/generated/sklearn.utils.extmath.randomized_svd.html

@schnell3526 schnell3526 changed the title fix bug fix minor issue with regard to randomized_svd() Dec 18, 2021
Copy link
Member

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution! I will run the tests locally to make sure and merge this PR if everything looks good.

Copy link
Member

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desilinguist desilinguist merged commit 94ac334 into EducationalTestingService:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants