Also re-order the structure matrix #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an oblique rotation has changed the variance order of the factors, the factors are reordered to ensure the first has the greatest variance. However, the structure matrix was assigned using the loadings before reordering, which causes these orders to sometimes be different. This can cause a lot of surprise for the user; if the factors have been given interpretation, or names, a user may be stumped that the resulting factor scores do not match this interpretation at all, and correlate with different items than the ones with the strongest loadings. The proposed change is to also reorder the structure matrix, so that the factor scores are always in the same order as the factor loadings. This should theoretically solve the issue everywhere, but the package authors should be careful in whether this change has repercussions elsewhere. See also: https://stackoverflow.com/questions/59284044/factor-order-differs-between-loadings-and-scoring-with-oblimin-rotation-how-i
There was a small error in the PR where sometimes structure is None which can not be reordered, which should be fixed now,
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 94.51% 94.53% +0.02%
==========================================
Files 5 5
Lines 820 823 +3
==========================================
+ Hits 775 778 +3
Misses 45 45
Continue to review full report at Codecov.
|
|
@jbiggsets and this one too? |
|
Thank you for this @keesmulder ! Do you happen to have the time to add a test for this change too? If so, that'd be much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an oblique rotation has changed the variance order of the factors, the factors are reordered to ensure the first has the greatest variance. However, the structure matrix was assigned using the loadings before reordering, which causes these orders to sometimes be different.
This can cause a lot of surprise for the user; if the factors have been given interpretation, or names, a user may be stumped that the resulting factor scores do not match this interpretation at all, and correlate with different items than the ones with the strongest loadings.
The proposed change is to also reorder the structure matrix, so that the factor scores are always in the same order as the factor loadings. This should theoretically solve the issue everywhere, but the package authors should be careful in whether this change has repercussions elsewhere.
See also:
https://stackoverflow.com/questions/59284044/factor-order-differs-between-loadings-and-scoring-with-oblimin-rotation-how-i