Skip to content

Fix to scipy.minimize changes #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Fix to scipy.minimize changes #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3c759c
Fix to scipy.minimize changes
ikeuchi-screen Jul 7, 2023
36a1fe6
Use latest codecov uploader in CI plan.
desilinguist Jul 7, 2023
538e431
Explicitly compute code coverage report.
desilinguist Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@ variables:
# set up the basic job
.runtests:
before_script:
- "conda create --prefix /root/factordev --channel conda-forge --file requirements.txt python=${PYVERSION} codecov nose nose-cov --yes --quiet"
- "conda create --prefix /root/factordev --channel conda-forge --file requirements.txt python=${PYVERSION} curl nose nose-cov --yes --quiet"
- /root/factordev/bin/pip install -e .
- /root/factordev/bin/curl -o /root/factordev/bin/codecov https://uploader.codecov.io/latest/linux/codecov
- chmod +x /root/factordev/bin/codecov
script:
- "/root/factordev/bin/nosetests ${TESTFILES}"
- "/root/factordev/bin/coverage xml"
after_script:
- /root/factordev/bin/codecov

Expand Down
2 changes: 1 addition & 1 deletion factor_analyzer/confirmatory_factor_analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ def fit(self, X, y=None):
# so that we can avoid using linear programming methods (e.g. SLSQP)
res = minimize(
self._objective,
x0,
x0.flatten(),
method="L-BFGS-B",
options={"maxiter": self.max_iter, "disp": self.disp},
bounds=self.bounds,
Expand Down