This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Repository navigation
Fixing any_unfulfilled_milestones in mobile course_enrollments API #280
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, why not use the function in this file:
get_course_milestones_fulfillment_paths?I see in some functions the
milestones_api.get_course_.....is being used, and only in one function theget_course_milestones_fulfillment_pathsin the file is being used. I do not see the difference in the result on one hand, and I do not see whyfrom milestones import api as milestones_apihas to be used many times?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other methods are using the API gateway, so I prefer keeping it like this. In the same hand, the
get_course_milestones_fulfillment_pathsfunction is rechecking the feature flag again, a reason that tells not call it.Let's wait for edX's review and see. But we still need to know the status of the changes if we need had to merge this before edX do.