Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically deploy the deployment manifests and service when TelemetryService presents. #1043

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

lizzy-0323
Copy link
Contributor

@lizzy-0323 lizzy-0323 commented Nov 8, 2024

What this PR does / why we need it:
Automatically deploy the deployment manifests and service when TelemetryService presents.
Will this PR make the community happier?

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes issue #790
How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 81.17647% with 16 lines in your changes missing coverage. Please review.

Project coverage is 33.44%. Comparing base (188f671) to head (e967309).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/k8s/controllers/telemetryservice_controller.go 81.17% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
+ Coverage   32.30%   33.44%   +1.13%     
==========================================
  Files          55       55              
  Lines        4723     4805      +82     
==========================================
+ Hits         1526     1607      +81     
+ Misses       3069     3058      -11     
- Partials      128      140      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@rhoninl rhoninl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizzy-0323 thanks for your contribute. Added some comments for this PR, please take a look

pkg/k8s/controllers/telemetryservice_controller.go Outdated Show resolved Hide resolved
pkg/k8s/controllers/telemetryservice_controller.go Outdated Show resolved Hide resolved
pkg/k8s/controllers/telemetryservice_controller.go Outdated Show resolved Hide resolved
pkg/k8s/controllers/telemetryservice_controller.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kris21he kris21he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good, except for some log msg comments.

Copy link
Collaborator

@rhoninl rhoninl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kris21he kris21he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93
Copy link
Contributor

Thank you for the contribution @lizzy-0323 !

@tomqin93 tomqin93 merged commit dad0e0c into Edgenesis:main Nov 19, 2024
17 checks passed
@lizzy-0323 lizzy-0323 deleted the issue-790 branch November 20, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants