Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to allow use of symfony 3.1 components. (only composer.json) #24

Closed
wants to merge 1 commit into from

Conversation

marcinlawnik
Copy link

New pull request, issue #22, pull request #23.

@zdenekdrahos
Copy link
Member

Does that composer.json works for you when you install phpqa globally?

I tried to clone your repo and upgrade components, but I wasn't able to upgrade every component:

git clone https://github.com/marcinlawnik/phpqa.git
composer install
composer update symfony/dependency-injection symfony/filesystem symfony/process symfony/finder symfony/yaml
# filesystem was updated to 2.8.8 -> add symfony/config to composer.json and repeat update
composer update symfony/config symfony/filesystem
# filesystem and config still has 2.8 version

symfony/config and symfony/filesystem can't be updated because of robo's dependency: henrikbjorn/lurker 1.1.0 requires symfony/config ~2.2. After updating robo to "~0.7|~1.0.0-beta1" I can update symfony/config and symfony/filesystem. But symfony/console is still in version 2.8 because of phploc. phploc support sf3 only in 3.X versions (php >= 5.6) and that's blocker for me.

Wouldn't be easier to install phpqa without composer? It seems very complicated to support every symfony component in version 3.X. I don't wanna upgrade just some components. I prefer complete solution or nothing (sf3 notice in readme).

@marcinlawnik
Copy link
Author

I got over it by removing all my global dependencies and just installing phpqa.
If the only way to go forward is to drop 5.4 and 5.5, the decision is up to you.

@zdenekdrahos
Copy link
Member

Closing the PR:

when robo releases v1.0, then components will be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants