fix(telemetry): frsky angles should be be signed (allow negative) #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug report that Roll/Pitch should be from -180 to +180, so needs to be a signed 16 bits number
pfeerick
changed the title
pfeerick
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
rationale for change: Using Ethos as the reference system, SR8/SR10+ show negative values for left roll (and back pitch), as opposed to the current values shown in ETX. This PR makes ETX match Ethos behaviour.
LGTM. Repeat tested with SR10+ on X9D+2019, Roll and Ptch both appear correct. Roll is basically 0 when level, and goes either 180 or -180 depending on which direction rolled. Pitch also starts at 0, and goes to either 90 or -90 depending on direction. AccX/AccY/AccZ appear to also be working correctly, going +ve or -ve depending on the direction the receiver is moved.
1 task
pfeerick
pushed a commit
that referenced
this pull request
Mar 26, 2024
felipemanga
pushed a commit
to felipemanga/edgetx
that referenced
this pull request
Mar 29, 2024
ThomasKuehne
pushed a commit
to ThomasKuehne/edgetx
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4729
Summary of changes:
Bug report that Roll/Pitch should be from -180 to +180, so needs to be a signed 16 bits number.
Change Angles to be processed as Signed int16