Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Bump action versions due to Node.js 16 EoL #4567

Merged
merged 9 commits into from
Jan 27, 2024

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Jan 26, 2024

Summary of changes:

  • Bump checkout and upload-artifact to Node.js 20 based actions. While this was announced Sept last year, looks like Github only just flipped the notifications toggle in the last day or so for warnings in the actions logs.
  • upload-artifact@v4 does has some major breaking changes, but it does not appear we use any of the changed functionality. whereby artifacts are immutable, so we can't just keep uploading to the same artifact in each matrix run.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@pfeerick pfeerick added the ci/cd Related to GitHub Actions and similar issues label Jan 26, 2024
@pfeerick pfeerick added this to the 2.10 milestone Jan 26, 2024
@pfeerick
Copy link
Member Author

d33325a should resolve the last of the Node16 depreciations warnings that can be done now. I can't remove the remaining one(s) until install-qt-action is updated... i.e. jurplel/install-qt-action#219

@pfeerick pfeerick merged commit 7c3e395 into main Jan 27, 2024
46 checks passed
@pfeerick pfeerick deleted the ghactions-to-node20 branch January 27, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Related to GitHub Actions and similar issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant