-
-
Notifications
You must be signed in to change notification settings - Fork 44
Heli wizard added #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Helicopter added as an option for the Wizard Loader
Added Heli Wizard Changed folder structure to match color radio structure remapped wizards to new image locations
Hi some things to think about.
Great work! |
Most definitely. There are still a lot of heli flyers with older helis. Plus, there's the whole choice thing ;)
Might just have to be wary of transmitters that don't have a T5 I'll be back to look at this properly in a few days... please feel free to ping me if that is longer than a week ;) |
@offer-shmuely One thing to consider with all of the wizards. They are designed to be used by new users to EdgeTX and load a basic setup for that particular model type, and get them in the air. Most experienced users will utilize their own template or copy an existing model as a starting point rather than starting from scratch using a wizard. I thought about making the initial selection for the curves" FLAT" for all ide ups (since that is what i run on all my FM's) and the modern ESC's spool much slower than the old word counterparts. as Peter said it comes down to choice. Do I put this one or that one first. Do I impose my preferences or make them decide by the order of the curves. Utilizing "T.Gain" instead of GYRO is a good idea, I used gyro due to its common use with other radio systems. Using the term "banks" tells me you use a "V" or kbar. Having announcements pre-programmed takes away from the "Customizable aspect". We all came to open source due to the fact that we could make it "Your radio , your way". The more that is added to the wizards makes it more and more like futaba, spectrum etc. Doing the simple tasks of setting announcements/warnings when something is changed is the initial steps to fully customizing it IMHO. Adding the name to the outputs is another good idea. Thank you. |
Thanks for good work |
Added output Names Chained gyro to T.Gain
@pfeerick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Needed to make a minor change as the colorlcd version was altering system TEXT_COLOR, but otherwise looks good.
To make the wizard more robust, since setSwashRing
is only available for HELI
firmware, it might be good to somehow check if that is available so it doesn't crash if the wizard is used to create a FB model when setSwashRing
is present. But that is food for a future revision.
edit: I just saw your question about output names, I'll do that as I need to check something else in the wizards anyway...
c480x272
bw128x64
bw212x64