-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wing wizard & plane wizard & dirs #107
Conversation
Need testing, I do not own a wing :-( |
btw, on the |
I fix the issue you find, Please do not merge it to 2.9, i think it needed to be tested on real plane (i do not own a wing myself) |
Might give me an |
@pfeerick I have many changes to the file structure, as well as an improved plane wizard |
You can include it in this PR, will make life a bit easer for both of us - no point keeping two branches/PRs in sync ;) |
add first widget pages add dual rate add expo add landing gear UI improuvments allow page-right/left navigation with touch fix acknowledge screen after create model
Plane wizard
|
no dual-rate on rudder
no dual-rate on rudder
@pfeerick can that pr be included in 2.9? |
? |
Ok, finally tried this out. the changes look fantastic. My only concern would be
|
the second one was checked with a real wind of a generous man on the club |
For first comment, that is a good question, |
There is no easy answer to that. If it is a beginner, then you add the burden on them to find out why it is doing what it is doing and then have to remove it. i.e. how many support requests are we going to get "I just created a plane using the wizard, and now my transmitter keeps telling me 0v?" If it's an intermediate to advanced user, it's fine... but then the question could be why are they using the wizard rather than a template, which has even more stuff set up. My issue is probably more one of the assumption that everyone is using a given RF system that expose that particular telemetry sensor type... which is why I think it is something done better through the presets concept ... "Add a low voltage warning" ... "what RF system are you using (if it can't guess from telemetry)?"... "is this the right sensor?" ... or something like that. |
edit: this PR started as wing only, but now it contain also enhancement to the plane wizard & directory restructure
Resolves #26
adding a wizard for wing (per old request)
also added a touch support for next/previous pages
maybe need better pictures (currently used the plane ones)