Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - renew jwt if expired #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature - renew jwt if expired #7

wants to merge 2 commits into from

Conversation

cikupin
Copy link

@cikupin cikupin commented Nov 2, 2019

  1. Add token expiration checking
  2. Add renew token functionality

@cikupin
Copy link
Author

cikupin commented Nov 2, 2019

@dynbit need your review for proposing new functionalities

dynbit
dynbit suggested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@dynbit dynbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe you could cover this new functionality with tests?

smooch.go
sc.mtx.Lock()
defer sc.mtx.Unlock()

jwtToken, err := GenerateJWT("app", sc.keyID, sc.secret)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before generating new token - a check is needed, to verify that it wasn't generated previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dynbit dynbit dynbit requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cikupin @dynbit