Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all pod configuration outside the create_pod_object method #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Drevanoorschot
Copy link
Contributor

All pod configuration is now a constant of the class keeping configuration and code more seperated. The only variable pod parameters are the pod run arguments that are still added in the create_pod_object method

@Drevanoorschot Drevanoorschot linked an issue Jun 24, 2020 that may be closed by this pull request
@AlexImb AlexImb self-requested a review June 24, 2020 22:42
Copy link
Member

@AlexImb AlexImb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor KubernetesAutoMLJob.create_pod_object()
2 participants