This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 881
Add Color-Presets to tailwind-config #956
Draft
Cahllagerfeld
wants to merge
1
commit into
nextjs-live
Choose a base branch
from
cahllagerfeld/issue-955
base: nextjs-live
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cahllagerfeld
changed the title
Cahllagerfeld/issue-955
Add Color-Presets to tailwind-config
Jan 10, 2022
gptkrsh
approved these changes
Jan 31, 2022
gptkrsh
suggested changes
Jan 31, 2022
Comment on lines
+9
to
+16
chili: "#C23100", | ||
"international-orange": "#FF5A00", | ||
koromiko: "#FFb95E", | ||
"dark-metal": "#202328", | ||
"dark-granite": "#65615E", | ||
"light-granite": "#D4D1C5", | ||
parsley: "#1D531D", | ||
"apple-green": "#3DA639", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion, can't we name this like, primary, secondary, tertiary etc... for ease understanding 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also prefer this
imlakshay08
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great! Keep up the good work!
priyankarpal
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 ⚡
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #955
I added the colors from the
branding
-repo to the tailwind config. I tried to be a bit creative with color-names, feel free to suggest others :DThere was an issue with the
generate
-script on postinstall. I removed it, as we dont need this anymore due to the next-js switch