Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] External links are missing target _blank #107

Closed
1 task done
Idrinth opened this issue Jun 29, 2024 · 1 comment · Fixed by #114
Closed
1 task done

[BUG] External links are missing target _blank #107

Idrinth opened this issue Jun 29, 2024 · 1 comment · Fixed by #114
Assignees
@Idrinth
Labels
bug Something isn't working 🚀 status: ready for dev You can request this issue

Comments

@Idrinth
Copy link
Contributor

Idrinth commented Jun 29, 2024

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

production

Version of CreatorsRegistry (for example "v0.19.0")

0.23.0

Description

External links currently open in the same window, leading to an unexpected leaving of the site. Affected are at least:

  • The github link in the header
  • Platform links on the user's profile

Steps to Reproduce

Github link:

  1. Open the website
  2. Left-Click the icon
  3. See the page not opening in a new tab

Profile links:

  1. Go to any profile page
  2. Left-Click any platform
  3. See the page not opening in a new tab

Screenshots

No response

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

add attributes to the mentioned links:

  • target _blank - to open in a new tan
  • rel noreferrer - if missing to prevent access from target site javascript
@Idrinth Idrinth added bug Something isn't working 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jun 29, 2024
@eddiejaoude
Copy link
Member

Thanks for raising 👍 I have assigned it to you

@eddiejaoude eddiejaoude added 🚀 status: ready for dev You can request this issue and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jun 30, 2024
Idrinth added a commit to Idrinth/CreatorsRegistry that referenced this issue Jun 30, 2024
@Idrinth
bugfix: make external links open in new tabs
6b42e81 
introduce an external link component to facilitate them always opening in new tabs
introduce rel=noreferrer to prevent javascript hijacking by target tabs

Closes EddieHubCommunity#107
@Idrinth Idrinth mentioned this issue Jun 30, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Idrinth Idrinth

Labels
bug Something isn't working 🚀 status: ready for dev You can request this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: make external links open in new tabs Idrinth/CreatorsRegistry
2 participants
@eddiejaoude @Idrinth