[ADMINAPI-776] Analyze Docker images with docker #89
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,9 +9,6 @@ on: | |
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| branches: | ||
| - main | ||
|
|
@@ -20,25 +17,90 @@ on: | |
| - "Docker/*" | ||
| workflow_dispatch: | ||
|
|
||
| env: | ||
| DOCKER_USERNAME: ${{ vars.DOCKER_USERNAME }} | ||
| DOCKER_HUB_TOKEN: ${{ secrets.DOCKER_HUB_TOKEN }} | ||
|
|
||
| jobs: | ||
| docker-analysis: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| security-events: write | ||
| pull-requests: write | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| dockerfile: | ||
| [ | ||
| { name: "api-database", path: "Docker/Settings/DB-Admin/pgsql/Dockerfile", type: "published" }, | ||
| { name: "postgres", path: "Docker/Dockerfile", type: "published" }, | ||
| { name: "database", path: "Docker/dbadmin.Dockerfile", type: "local" }, | ||
| { name: "development", path: "Docker/dev.Dockerfile", type: "local" }, | ||
| ] | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | ||
| with: | ||
| fetch-depth: 0w | ||
|
|
||
| - name: Copy application folder to docker context | ||
| if: ${{ matrix.dockerfile.type == 'local' }} | ||
| run: | | ||
| mkdir Docker/Application | ||
| cp -r ./Application/EdFi.Ods.AdminApi ./Docker/Application | ||
| cp ./Application/NuGet.Config ./Docker/Application | ||
|
|
||
| - name: Set Version Numbers | ||
| if: ${{ matrix.dockerfile.type == 'published' }} | ||
| id: versions | ||
| run: | | ||
| tag=$(git describe --tags $(git rev-list --tags --max-count=1)) | ||
|
|
||
| if [[ $tag =~ "Pre-Release" ]] | ||
| then | ||
| # Remove Pre-Release prefix | ||
| prefix="Pre-Release-" | ||
| package=${tag#"$prefix"} | ||
| else | ||
| package=${tag} | ||
| fi | ||
|
|
||
| SEMVERSION=${package:1} # strip off the leading 'v' | ||
| echo "Current version: $SEMVERSION" | ||
| echo "VERSION=$SEMVERSION" >> $GITHUB_OUTPUT | ||
|
|
||
| - uses: hadolint/hadolint-action@54c9adbab1582c2ef04b2016b760714a4bfde3cf # v3.1.0 | ||
| name: Run Linter on ${{ matrix.dockerfile.name }} Dockerfile | ||
| with: | ||
| dockerfile: ${{ matrix.dockerfile.path }} | ||
| failure-threshold: error | ||
|
|
||
| - name: Log in to Docker Hub | ||
| uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 | ||
| with: | ||
| username: ${{ env.DOCKER_USERNAME }} | ||
| password: ${{ env.DOCKER_HUB_TOKEN }} | ||
|
Contributor
There was a problem hiding this comment. Docker Scout requires authorization? I suppose that means we get only a few (was it 3?) free repositories this way. Are we able to just run
Contributor
There was a problem hiding this comment. I just tried it and did not work. Must have Docker Hub login. Please help me understand what we get for free and what we would need to pay for.
Contributor
Author
There was a problem hiding this comment. This was confusing for me too, basically, to use Docker Scout we need to be logged in but does not count into the 3 allowed repositories. The limit is only for the website enabled ones (that provides some graphs and additional information). This repo is running for 4 containers, and none of those containers are enabled in docker scout and two of those not even exist in docker hub. |
||
|
|
||
| - name: Build | ||
| run: | | ||
| path=${{matrix.dockerfile.path}} | ||
| folder=${path%/*} | ||
| cd $folder | ||
| dockerfile=$(echo ${{matrix.dockerfile.path}} | awk -F"/" '{print $NF}') | ||
|
|
||
| docker build -f $dockerfile -t ${{ matrix.dockerfile.name }} --build-arg="VERSION=${{ steps.versions.outputs.VERSION }}" . | ||
|
|
||
| - name: Analyze | ||
| uses: docker/scout-action@7c61653c2736d21969dd4593fde76c670d4a86cb # v1.2.0 | ||
| with: | ||
| command: cves | ||
| image: local://${{ matrix.dockerfile.name }} | ||
|
Contributor
Author
There was a problem hiding this comment. adding |
||
| sarif-file: sarif-${{ matrix.dockerfile.name }}.output.json | ||
| summary: true | ||
|
|
||
| - name: Upload SARIF result | ||
| id: upload-sarif | ||
| if: ${{ github.event_name != 'pull_request_target' }} | ||
| uses: github/codeql-action/upload-sarif@df32e399139a3050671466d7d9b3cbacc1cfd034 #codeql-bundle-v2.15.2 | ||
| with: | ||
| sarif_file: sarif-${{ matrix.dockerfile.name }}.output.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This work is being triggered only when the PR includes a change into the Dockerfiles or the action, the issue with this is that it can cause the analysis to go without running for a while, therefore, if there are new vulnerabilities it can go unnoticed.
I'm adding this run after merging the PRs to avoid adding noise to the PR itself since current behavior only shows the status, it does not forces or fails the build when new vulnerabilities appear.