Skip to content
This repository was archived by the owner on Dec 19, 2025. It is now read-only.

[ADMINAPI-1325] - Update Ed-Fi API Specifications repo with new spec for 2.3.0#384

Merged
jagudelo-gap merged 3 commits intomainfrom
ADMINAPI-1323-3
Dec 2, 2025
Merged

[ADMINAPI-1325] - Update Ed-Fi API Specifications repo with new spec for 2.3.0#384
jagudelo-gap merged 3 commits intomainfrom
ADMINAPI-1323-3

Conversation

@DavidJGapCR
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Test Results

338 tests   337 ✅  15s ⏱️
  4 suites    1 💤
  4 files      0 ❌

Results for commit fde143f.

♻️ This comment has been updated with latest results.

}

public void BuildForVersions(string authorizationPolicy, params AdminApiVersions.AdminApiVersion[] versions)
public void BuildForVersions(string authorizationPolicy, bool display409 = false, params AdminApiVersions.AdminApiVersion[] versions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidJGapCR why would we hide 409 from the output?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only place where the Admin Api can actually return 409 is when the user is creating an Application and the name already exists

version: v1
version: 1.4.3
title: "Ed-Fi Admin API"
description: The Ed-Fi Admin API is a REST API-based administrative interface for managing vendors, applications, client credentials, and authorization rules for accessing an Ed-Fi API.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that we have a copy of the specification file here as well as in the API-Specifications repository. The one in the other repository is the official standard. It should have title: "Ed-Fi Management API". But here in this AdminAPI repository, it is fine to leave "Ed-Fi Admin API" since it is now referring to the specific application.

@DavidJGapCR DavidJGapCR marked this pull request as ready for review November 28, 2025 15:50
@DavidJGapCR DavidJGapCR changed the title [ADMINAPI-1323] - Update Ed-Fi API Specifications repo with new spec for 2.3.0 [ADMINAPI-1325] - Update Ed-Fi API Specifications repo with new spec for 2.3.0 Nov 28, 2025
@jagudelo-gap jagudelo-gap merged commit 0a7d5b3 into main Dec 2, 2025
20 checks passed
@jagudelo-gap jagudelo-gap deleted the ADMINAPI-1323-3 branch December 2, 2025 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants