This repository was archived by the owner on Dec 19, 2025. It is now read-only.
[ADMINAPI-1314] - POST to profile with line breaks returns 400 with nice description#377
Merged
dfernandez-gap merged 3 commits intomainfrom Nov 11, 2025
Merged
[ADMINAPI-1314] - POST to profile with line breaks returns 400 with nice description#377dfernandez-gap merged 3 commits intomainfrom
dfernandez-gap merged 3 commits intomainfrom
Conversation
Test Results338 tests 337 ✅ 14s ⏱️ Results for commit e4d0d81. ♻️ This comment has been updated with latest results. |
dfernandez-gap
approved these changes
Nov 11, 2025
27f2892 to
e4d0d81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user tried to send a post with an invalid JSON he should get a descriptive error message with a 400 bad request.
I tried to add a new e2e test to cover this scenario but we have a limitation associated to how postman saves the collections.
Since postman saves the saves in a JSON format, when I export the file it escapes the line breaks, making the test invalid. So, I added it (first commit) and then I had to remove it (second commit).