This repository was archived by the owner on Dec 19, 2025. It is now read-only.
[ADMINAPI-1311] - Fixes build warnings in the new EdFi.Ods.AdminApi.V1 project #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results238 tests 237 ✅ 9s ⏱️ Results for commit 36f6052. ♻️ This comment has been updated with latest results. |
| var columnName = property.GetColumnName(tableId) ?? property.GetDefaultColumnName(tableId); | ||
| property.SetColumnName(columnName.ToLowerInvariant()); | ||
| if (columnName != null) | ||
| property.SetColumnName(columnName.ToLowerInvariant()); |
There was a problem hiding this comment.
I'm surprised this was accepted without { }. I thought our rules did not allow that.
DavidJGapCR
force-pushed
the
ADMINAPI-1311
branch
from
c85859e to
36f6052
Compare
CSR2017
approved these changes
Sep 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.