Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed broken links #7309

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Removed broken links #7309

merged 4 commits into from
Oct 3, 2022

Conversation

julian-st
Copy link
Contributor

What does this PR do?

Removed broken links for ruby on rails and visual basic 2010 book, alternatives are already there

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • [x ] Read our contributing guidelines.
  • [ x] Search for duplicates.
  • [ x] Include author(s) and platform where appropriate.
  • [ x] Put lists in alphabetical order, correct spacing.
  • [ x] Add needed indications (PDF, access notes, under construction).
  • [x ] Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Copy link
Member

@LuigiImVector LuigiImVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respect the formatting guidelines

@@ -249,6 +248,5 @@

### Visual Basic

* [Einstieg in Visual Basic 2010](http://openbook.rheinwerk-verlag.de/einstieg_vb_2010) - Thomas Theis (Online)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@davorpa davorpa Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it different from the 2012 version? If differs, please, re-adding again due to was removed with upstream merge b39be9c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2012 version has more chapters, all right

@LuigiImVector
Copy link
Member

Related to #6942

@LuigiImVector LuigiImVector added waiting for changes PR has been reviewed and changes/suggestions requested 🗣️ locale:de Resources addressing "German / Deutsch" language labels Oct 2, 2022
@davorpa davorpa added the urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs. label Oct 3, 2022
@eshellman eshellman merged commit 9f1490a into EbookFoundation:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗣️ locale:de Resources addressing "German / Deutsch" language urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs. waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants