Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Free courses and Resource in khmer language. #6156

Merged
merged 12 commits into from
Oct 12, 2021

Conversation

sambatlim
Copy link
Contributor

Added: Free courses and Resource in khmer language.

What does this PR do?

Add resource(s)

For resources

This PR contain resources to learn to code in khmer language

This PR will help Cambodian people who just learn to code to learn faster and gain more knowleges from all the resources provided.

It is completely free because all the resources is public in Youtube, article and public git repository.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Added: Free courses and Resource in khmer language.
@davorpa davorpa added linter error Please, correct build errors found by linter! waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 11, 2021
@sambatlim sambatlim closed this Oct 11, 2021
@sambatlim sambatlim reopened this Oct 11, 2021
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, follow the guidelines seen in other listings

courses/free-courses-kh.md Outdated Show resolved Hide resolved
courses/free-courses-kh.md Outdated Show resolved Hide resolved
courses/free-courses-kh.md Outdated Show resolved Hide resolved
courses/free-courses-kh.md Outdated Show resolved Hide resolved
Fixed: linter error.
Added: khmer language  course to readme.
@eshellman
Copy link
Collaborator

iso language code is km, not kh

@eshellman eshellman removed the linter error Please, correct build errors found by linter! label Oct 11, 2021
Copy link
Collaborator

@eshellman eshellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please apply review comments to each resource.

courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
Removed non khmer courses, changed link youtube, and  fix Alphabetized order
@davorpa davorpa self-requested a review October 11, 2021 15:43
README.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
courses/free-courses-km.md Outdated Show resolved Hide resolved
@davorpa davorpa added the question Needs clarification by involved users / reviewers label Oct 11, 2021
@davorpa davorpa mentioned this pull request Oct 11, 2021
39 tasks

### Javascript

* [Blog post - What new in each version of Modern Javascript - ECMAScript(ES) from ES6 - ES11🔥](https://sambat-tech.netlify.app/modern-javascript-what-new/) - Sambat Lim
Copy link
Member

@davorpa davorpa Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I said about "blog post" (#6156 (comment)) is a doubt 😉. What do you think @eshellman ?

Suggested change
* [Blog post - What new in each version of Modern Javascript - ECMAScript(ES) from ES6 - ES11🔥](https://sambat-tech.netlify.app/modern-javascript-what-new/) - Sambat Lim
* [What new in each version of Modern Javascript - ECMAScript(ES) from ES6 - ES11🔥](https://sambat-tech.netlify.app/modern-javascript-what-new/) - Sambat Lim

@eshellman
Copy link
Collaborator

Thanks for persisting in this!

@eshellman eshellman merged commit 5abc8cd into EbookFoundation:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Needs clarification by involved users / reviewers waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants