-
-
Notifications
You must be signed in to change notification settings - Fork 62.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated #4569
Updated #4569
Conversation
free-programming-books-tr.md
Outdated
* [Android Geleceği Yazanlar](https://gelecegiyazanlar.turkcell.com.tr/konu/android) | ||
* [Android Dersleri] (http://umiitkose.com/android/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, the reason your Travis CI build fails is because of improper ordering and spacing
* [Android Geleceği Yazanlar](https://gelecegiyazanlar.turkcell.com.tr/konu/android) | |
* [Android Dersleri] (http://umiitkose.com/android/) | |
* [Android Dersleri] (http://umiitkose.com/android/) | |
* [Android Geleceği Yazanlar](https://gelecegiyazanlar.turkcell.com.tr/konu/android) |
Swap the ordering so it is alphabetical order as suggested by the CONTRIBUTING file.
free-programming-books-tr.md
Outdated
|
||
|
||
### C | ||
|
||
* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul) | ||
* [Programlamaya Giriş Ders Notları](http://web.itu.edu.tr/uyar/programlama) - [H.Turgut Uyar](http://web.itu.edu.tr/uyar) | ||
* [C Programlama Dersleri](https://www.youtube.com/watch?v=FtaKEn2f2qI&list=PLfzhcDNz4tlXOvEE7z_u3gEqFO3nwIZ5i&index=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should belong in a different file location "free-courses-tr.md" since it is a Youtube video and not a book.
Also, since that file does not exist yet, you are able to create a new file and add the video there!
free-programming-books-tr.md
Outdated
### C | ||
|
||
* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul) | ||
* [Programlamaya Giriş Ders Notları](http://web.itu.edu.tr/uyar/programlama) - [H.Turgut Uyar](http://web.itu.edu.tr/uyar) | ||
* [C Programlama Dersleri](https://www.youtube.com/watch?v=FtaKEn2f2qI&list=PLfzhcDNz4tlXOvEE7z_u3gEqFO3nwIZ5i&index=1) | ||
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### C | |
* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul) | |
* [Programlamaya Giriş Ders Notları](http://web.itu.edu.tr/uyar/programlama) - [H.Turgut Uyar](http://web.itu.edu.tr/uyar) | |
* [C Programlama Dersleri](https://www.youtube.com/watch?v=FtaKEn2f2qI&list=PLfzhcDNz4tlXOvEE7z_u3gEqFO3nwIZ5i&index=1) | |
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html) | |
### C | |
* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul) | |
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html) | |
* [Programlamaya Giriş Ders Notları](http://web.itu.edu.tr/uyar/programlama) - [H.Turgut Uyar](http://web.itu.edu.tr/uyar) |
- I removed the YouTube video resource and moved the "GNU C..." resource to be in the correct position.
free-programming-books-tr.md
Outdated
* [CSS Egitim Serisi] (https://www.youtube.com/playlist?list=PL_f2F0Oyaj4-RyFL8mkfjYjEVCmJhWDQ3) | ||
* [Bootstrap 4 ile Responsive Web Tasarimi](https://www.youtube.com/playlist?list=PL-Hkw4CrSVq-xwLUQ0-OIA46mKwYeaxXR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [CSS Egitim Serisi] (https://www.youtube.com/playlist?list=PL_f2F0Oyaj4-RyFL8mkfjYjEVCmJhWDQ3) | |
* [Bootstrap 4 ile Responsive Web Tasarimi](https://www.youtube.com/playlist?list=PL-Hkw4CrSVq-xwLUQ0-OIA46mKwYeaxXR) |
Delete both since YouTube playlist videos and not books.
You can add to the new file you create!!
free-programming-books-tr.md
Outdated
@@ -69,6 +73,7 @@ | |||
|
|||
* [Html'e Giriş](http://www.htmldersleri.org) | |||
* [Html'e Yolculuk](https://github.com/paufsc/journey-to-html) | |||
* [Html Egitim Serisi](https://www.youtube.com/playlist?list=PL_f2F0Oyaj4-Qro_C0ixzMWpCiogfXxKE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [Html Egitim Serisi](https://www.youtube.com/playlist?list=PL_f2F0Oyaj4-Qro_C0ixzMWpCiogfXxKE) |
Similar reasoning since Youtube video and not a book
free-programming-books-tr.md
Outdated
@@ -117,6 +122,7 @@ | |||
### Django | |||
|
|||
* [Django Girls Eğitimi](https://tutorial.djangogirls.org/tr) (1.11) (HTML) (:construction: *in process*) | |||
* [Django 101](https://www.youtube.com/playlist?list=PLPrHLaayVkhny4WRNp05C1qRl1Aq3Wswh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [Django 101](https://www.youtube.com/playlist?list=PLPrHLaayVkhny4WRNp05C1qRl1Aq3Wswh) |
Similar reasoning since Youtube video and not a book.
I fixed the errors you said, but Travis CI went wrong again. |
free-programming-books-tr.md
Outdated
|
||
|
||
|
||
### iOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 3 blank lines here(lines 74-76), should only be 2.
### iOS |
free-programming-books-tr.md
Outdated
* [GNU Bash Başvuru Kılavuzu](http://belgeler.org/bashref/bashref.html) | ||
* [Linux Belgeleri](http://belgeler.org/howto/howtos.html) | ||
* [Linux Sistem Yöneticisinin Kılavuzu](http://belgeler.org/sag/sag.html) | ||
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [GNU Bash Başvuru Kılavuzu](http://belgeler.org/bashref/bashref.html) | |
* [Linux Belgeleri](http://belgeler.org/howto/howtos.html) | |
* [Linux Sistem Yöneticisinin Kılavuzu](http://belgeler.org/sag/sag.html) | |
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf) | |
* [GNU Bash Başvuru Kılavuzu](http://belgeler.org/bashref/bashref.html) | |
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf) (PDF) | |
* [Linux Belgeleri](http://belgeler.org/howto/howtos.html) | |
* [Linux Sistem Yöneticisinin Kılavuzu](http://belgeler.org/sag/sag.html) |
2 part fix here:
- Alphabetical order
- Indicating it is a PDF extension with (PDF)
Hey, I found 3 more errors from this commit. Fix those up and the Travis CI build will work. Your latest commit changes are flawless, it was your second to last one that is causing problems. |
build failed again... may you tell me what is wrong now? |
Yeah definitely so there's still the old errors from lines 96 ish that I mentioned here Summarizing again:
There's also a new error not caused by you but someone else's file in the "free-programming-books-fa_IR.md" that got merged I think. It's causing errors in other people's PR's as well. I will address this as a new issue soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just added one more comment, it's preferred to use HTTPS over HTTP where available.
You can get more guidance on the formatting and conventions in this repository by checking out the contribution guide.
free-programming-books-tr.md
Outdated
@@ -25,12 +25,14 @@ | |||
|
|||
### Android | |||
|
|||
* [Android Dersleri] (http://umiitkose.com/android/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page is available with HTTPS, could we please use that instead?
* [Android Dersleri] (http://umiitkose.com/android/) | |
* [Android Dersleri](https://umiitkose.com/android/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've dropped a few more comments, sorry about that!
If possible, it's favorable to also add the author after the resource.
free-programming-books-tr.md
Outdated
* [Android Geleceği Yazanlar](https://gelecegiyazanlar.turkcell.com.tr/konu/android) | ||
|
||
|
||
### C | ||
|
||
* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul) | ||
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the space between the title and link?
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html) | |
* [GNU C Kütüphanesi Basvuru Klavuzu](http://www.belgeler.org/glibc/glibc.html) |
free-programming-books-tr.md
Outdated
@@ -25,12 +25,14 @@ | |||
|
|||
### Android | |||
|
|||
* [Android Dersleri] (httpS://umiitkose.com/android) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the space between the title and the link?
* [Android Dersleri] (httpS://umiitkose.com/android) | |
* [Android Dersleri](https://umiitkose.com/android) |
free-programming-books-tr.md
Outdated
@@ -89,6 +91,7 @@ | |||
### Linux | |||
|
|||
* [GNU Bash Başvuru Kılavuzu](http://belgeler.org/bashref/bashref.html) | |||
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf)(PDF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please type GNU in all uppercase?
There should also be a space before the (PDF) tag.
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf)(PDF) | |
* [GNU Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf) (PDF) |
I fixed everything you commented but it failed again |
Don't worry about the build failures for this particular pull request, it's not your fault. You can check the build failures that occurred yourself here: It doesn't list any linting failures for any files that you changed. ^-^ |
thank you |
hey, are there any updates? |
Wow, this PR had quite a struggle! Thanks for persevering - we had well ove a thousand PRs to manage over the last 6 weeks. and welcome to free-programming-books! |
* Updated * fixed * Update free-programming-books-tr.md * Update free-programming-books-tr.md * Update free-programming-books-tr.md * Update free-programming-books-tr.md * Update free-programming-books-tr.md Co-authored-by: Eric Hellman <[email protected]>
Hacktoberfest notes:
What does this PR do?
Add Resources
Why is this valuable (or not)?
How do we know it's really free?
All trainings shared about their owners
For book lists, is it a book? For course lists, is it a course? etc.
Both
Checklist: