Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated #4569

Merged
merged 8 commits into from
Nov 13, 2020
Merged

Updated #4569

merged 8 commits into from
Nov 13, 2020

Conversation

mtbun
Copy link
Contributor

@mtbun mtbun commented Oct 21, 2020

Hacktoberfest notes:

  • due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
  • please read our contributing guidelines
  • be sure to check the output of Travis-CI for linter errors
  • if this is your first open source contribution, make sure it's not your last!

What does this PR do?

Add Resources

Why is this valuable (or not)?

How do we know it's really free?

All trainings shared about their owners

For book lists, is it a book? For course lists, is it a course? etc.

Both

Checklist:

  • Not a duplicate
  • Included author(s) if appropriate
  • Lists are in alphabetical order
  • Needed indications added (PDF, access notes, under construction)

Comment on lines 28 to 29
* [Android Geleceği Yazanlar](https://gelecegiyazanlar.turkcell.com.tr/konu/android)
* [Android Dersleri] (http://umiitkose.com/android/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, the reason your Travis CI build fails is because of improper ordering and spacing

Suggested change
* [Android Geleceği Yazanlar](https://gelecegiyazanlar.turkcell.com.tr/konu/android)
* [Android Dersleri] (http://umiitkose.com/android/)
* [Android Dersleri] (http://umiitkose.com/android/)
* [Android Geleceği Yazanlar](https://gelecegiyazanlar.turkcell.com.tr/konu/android)

Swap the ordering so it is alphabetical order as suggested by the CONTRIBUTING file.



### C

* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul)
* [Programlamaya Giriş Ders Notları](http://web.itu.edu.tr/uyar/programlama) - [H.Turgut Uyar](http://web.itu.edu.tr/uyar)
* [C Programlama Dersleri](https://www.youtube.com/watch?v=FtaKEn2f2qI&list=PLfzhcDNz4tlXOvEE7z_u3gEqFO3nwIZ5i&index=1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should belong in a different file location "free-courses-tr.md" since it is a Youtube video and not a book.

Also, since that file does not exist yet, you are able to create a new file and add the video there!

Comment on lines 32 to 37
### C

* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul)
* [Programlamaya Giriş Ders Notları](http://web.itu.edu.tr/uyar/programlama) - [H.Turgut Uyar](http://web.itu.edu.tr/uyar)
* [C Programlama Dersleri](https://www.youtube.com/watch?v=FtaKEn2f2qI&list=PLfzhcDNz4tlXOvEE7z_u3gEqFO3nwIZ5i&index=1)
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### C
* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul)
* [Programlamaya Giriş Ders Notları](http://web.itu.edu.tr/uyar/programlama) - [H.Turgut Uyar](http://web.itu.edu.tr/uyar)
* [C Programlama Dersleri](https://www.youtube.com/watch?v=FtaKEn2f2qI&list=PLfzhcDNz4tlXOvEE7z_u3gEqFO3nwIZ5i&index=1)
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html)
### C
* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul)
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html)
* [Programlamaya Giriş Ders Notları](http://web.itu.edu.tr/uyar/programlama) - [H.Turgut Uyar](http://web.itu.edu.tr/uyar)
  • I removed the YouTube video resource and moved the "GNU C..." resource to be in the correct position.

Comment on lines 43 to 44
* [CSS Egitim Serisi] (https://www.youtube.com/playlist?list=PL_f2F0Oyaj4-RyFL8mkfjYjEVCmJhWDQ3)
* [Bootstrap 4 ile Responsive Web Tasarimi](https://www.youtube.com/playlist?list=PL-Hkw4CrSVq-xwLUQ0-OIA46mKwYeaxXR)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [CSS Egitim Serisi] (https://www.youtube.com/playlist?list=PL_f2F0Oyaj4-RyFL8mkfjYjEVCmJhWDQ3)
* [Bootstrap 4 ile Responsive Web Tasarimi](https://www.youtube.com/playlist?list=PL-Hkw4CrSVq-xwLUQ0-OIA46mKwYeaxXR)

Delete both since YouTube playlist videos and not books.
You can add to the new file you create!!

@@ -69,6 +73,7 @@

* [Html'e Giriş](http://www.htmldersleri.org)
* [Html'e Yolculuk](https://github.com/paufsc/journey-to-html)
* [Html Egitim Serisi](https://www.youtube.com/playlist?list=PL_f2F0Oyaj4-Qro_C0ixzMWpCiogfXxKE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Html Egitim Serisi](https://www.youtube.com/playlist?list=PL_f2F0Oyaj4-Qro_C0ixzMWpCiogfXxKE)

Similar reasoning since Youtube video and not a book

@@ -117,6 +122,7 @@
### Django

* [Django Girls Eğitimi](https://tutorial.djangogirls.org/tr) (1.11) (HTML) (:construction: *in process*)
* [Django 101](https://www.youtube.com/playlist?list=PLPrHLaayVkhny4WRNp05C1qRl1Aq3Wswh)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Django 101](https://www.youtube.com/playlist?list=PLPrHLaayVkhny4WRNp05C1qRl1Aq3Wswh)

Similar reasoning since Youtube video and not a book.

@mtbun
Copy link
Contributor Author

mtbun commented Oct 21, 2020

I fixed the errors you said, but Travis CI went wrong again.

Comment on lines 74 to 77



### iOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 blank lines here(lines 74-76), should only be 2.

Suggested change
### iOS

Comment on lines 94 to 97
* [GNU Bash Başvuru Kılavuzu](http://belgeler.org/bashref/bashref.html)
* [Linux Belgeleri](http://belgeler.org/howto/howtos.html)
* [Linux Sistem Yöneticisinin Kılavuzu](http://belgeler.org/sag/sag.html)
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [GNU Bash Başvuru Kılavuzu](http://belgeler.org/bashref/bashref.html)
* [Linux Belgeleri](http://belgeler.org/howto/howtos.html)
* [Linux Sistem Yöneticisinin Kılavuzu](http://belgeler.org/sag/sag.html)
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf)
* [GNU Bash Başvuru Kılavuzu](http://belgeler.org/bashref/bashref.html)
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf) (PDF)
* [Linux Belgeleri](http://belgeler.org/howto/howtos.html)
* [Linux Sistem Yöneticisinin Kılavuzu](http://belgeler.org/sag/sag.html)

2 part fix here:

  1. Alphabetical order
  2. Indicating it is a PDF extension with (PDF)

@kadhirash
Copy link
Member

I fixed the errors you said, but Travis CI went wrong again.

Hey, I found 3 more errors from this commit.

Fix those up and the Travis CI build will work.

Your latest commit changes are flawless, it was your second to last one that is causing problems.

@mtbun
Copy link
Contributor Author

mtbun commented Oct 22, 2020

build failed again... may you tell me what is wrong now?

@kadhirash
Copy link
Member

Yeah definitely so there's still the old errors from lines 96 ish that I mentioned here

Summarizing again:

  • Alphabetical order
  • Indicating it is a PDF extension with (PDF)

There's also a new error not caused by you but someone else's file in the "free-programming-books-fa_IR.md" that got merged I think. It's causing errors in other people's PR's as well. I will address this as a new issue soon.

Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just added one more comment, it's preferred to use HTTPS over HTTP where available.

You can get more guidance on the formatting and conventions in this repository by checking out the contribution guide.

@@ -25,12 +25,14 @@

### Android

* [Android Dersleri] (http://umiitkose.com/android/)
Copy link
Member

@SethFalco SethFalco Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is available with HTTPS, could we please use that instead?

Suggested change
* [Android Dersleri] (http://umiitkose.com/android/)
* [Android Dersleri](https://umiitkose.com/android/)

Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've dropped a few more comments, sorry about that!
If possible, it's favorable to also add the author after the resource.

* [Android Geleceği Yazanlar](https://gelecegiyazanlar.turkcell.com.tr/konu/android)


### C

* [C Programlama Diline Giriş](http://www1.gantep.edu.tr/~bingul/c/index.php) - [Ahmet Bingül](http://www1.gantep.edu.tr/~bingul)
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the space between the title and link?

Suggested change
* [GNU C Kütüphanesi Basvuru Klavuzu] (http://www.belgeler.org/glibc/glibc.html)
* [GNU C Kütüphanesi Basvuru Klavuzu](http://www.belgeler.org/glibc/glibc.html)

@@ -25,12 +25,14 @@

### Android

* [Android Dersleri] (httpS://umiitkose.com/android)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the space between the title and the link?

Suggested change
* [Android Dersleri] (httpS://umiitkose.com/android)
* [Android Dersleri](https://umiitkose.com/android)

@@ -89,6 +91,7 @@
### Linux

* [GNU Bash Başvuru Kılavuzu](http://belgeler.org/bashref/bashref.html)
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf)(PDF)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please type GNU in all uppercase?
There should also be a space before the (PDF) tag.

Suggested change
* [Gnu Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf)(PDF)
* [GNU Linux Komutlari](https://www.fullportal.org/GNULINUX/Komutlar/GNULINUXKOMUTLAR.pdf) (PDF)

@mtbun
Copy link
Contributor Author

mtbun commented Oct 22, 2020

I fixed everything you commented but it failed again

@SethFalco
Copy link
Member

SethFalco commented Oct 22, 2020

I fixed everything you commented but it failed again

Don't worry about the build failures for this particular pull request, it's not your fault.
It seems a pull request that had failures was merged is all, that will be addressed soon!

You can check the build failures that occurred yourself here:
https://travis-ci.com/github/EbookFoundation/free-programming-books/builds/191622929

It doesn't list any linting failures for any files that you changed. ^-^

@mtbun
Copy link
Contributor Author

mtbun commented Oct 22, 2020

thank you

@mtbun
Copy link
Contributor Author

mtbun commented Oct 23, 2020

hey, are there any updates?

@eshellman
Copy link
Collaborator

Wow, this PR had quite a struggle! Thanks for persevering - we had well ove a thousand PRs to manage over the last 6 weeks. and welcome to free-programming-books!

@eshellman eshellman merged commit 4147a28 into EbookFoundation:master Nov 13, 2020
tt512 pushed a commit to tt512/free-programming-books that referenced this pull request May 7, 2021
* Updated

* fixed

* Update free-programming-books-tr.md

* Update free-programming-books-tr.md

* Update free-programming-books-tr.md

* Update free-programming-books-tr.md

* Update free-programming-books-tr.md

Co-authored-by: Eric Hellman <[email protected]>
@davorpa davorpa added the 🗣️ locale:tr Resources addressing "Turkish / Türkçe" language label Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗣️ locale:tr Resources addressing "Turkish / Türkçe" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants