[fix] Use body for POST/PUT/PATCH and query for GET/DELETE requests (#…

…310)

- Use body for POST/PUT/PATCH and query for GET/DELETE requests
- Re-record all cassettes

Co-authored-by: jchen293 <[email protected]>

CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG
 
+## Next release
+
+- Send GET requests as query parameters instead of JSON body parameters
+- Fix get_next_page_of_children function for User service with correct filter key
+
 ## v6.4.0 (2024-07-24)
 
 - Adds new `Claim` service for filing claims on EasyPost shipments and insurances

lib/easypost/client.rb

@@ -74,17 +74,17 @@ def initialize(api_key:, read_timeout: 60, open_timeout: 30, api_base: 'https://
   #
   # @param method [Symbol] the HTTP Verb (get, method, put, post, etc.)
   # @param endpoint [String] URI path of the resource
-  # @param body [Object] (nil) object to be dumped to JSON
+  # @param params [Object] (nil) object to be used as the request parameters
   # @param api_version [String] the version of API to hit
   # @raise [EasyPost::Error] if the response has a non-2xx status code
   # @return [Hash] JSON object parsed from the response body
   def make_request(
     method,
     endpoint,
-    body = nil,
+    params = nil,
     api_version = EasyPost::InternalUtilities::Constants::API_VERSION
   )
-    response = @http_client.request(method, endpoint, nil, body, api_version)
+    response = @http_client.request(method, endpoint, nil, params, api_version)
 
     potential_error = EasyPost::Errors::ApiError.handle_api_error(response)
     raise potential_error unless potential_error.nil?

lib/easypost/http_client.rb

@@ -14,26 +14,35 @@ def request(
     method,
     path,
     headers = nil,
-    body = nil,
+    params = nil,
     api_version = EasyPost::InternalUtilities::Constants::API_VERSION
   )
     # Remove leading slash from path.
     path = path[1..] if path[0] == '/'
 
-    uri = URI.parse("#{@base_url}/#{api_version}/#{path}")
     headers = @config[:headers].merge(headers || {})
-    serialized_body = JSON.dump(EasyPost::InternalUtilities.objects_to_ids(body)) if body
     open_timeout = @config[:open_timeout]
     read_timeout = @config[:read_timeout]
     request_timestamp = Time.now
     request_uuid = SecureRandom.uuid
 
+    uri = URI.parse("#{@base_url}/#{api_version}/#{path}")
+    serialized_body = nil
+
+    if params
+      if [:get, :delete].include?(method)
+        uri.query = URI.encode_www_form(params)
+      elsif params
+        serialized_body = JSON.dump(EasyPost::InternalUtilities.objects_to_ids(params))
+      end
+    end
+
     if EasyPost::Hooks.any_subscribers?(:request)
       request_context = EasyPost::Hooks::RequestContext.new(
         method: method,
         path: uri.to_s,
         headers: headers,
-        request_body: body,
+        request_body: serialized_body,
         request_timestamp: request_timestamp,
         request_uuid: request_uuid,
       )

lib/easypost/services/user.rb

@@ -90,7 +90,7 @@ def all_children(params = {})
   def get_next_page_of_children(collection, page_size = nil)
     raise EasyPost::Errors::EndOfPaginationError.new unless more_pages?(collection)
 
-    params = { before_id: collection.children.last.id }
+    params = { after_id: collection.children.last.id }
     params[:page_size] = page_size unless page_size.nil?
 
     all_children(params)