Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook fixture, addCreditCard params #348

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Aug 15, 2024

Description

  1. Uses the new webhook fixture data (had to update escaping logic due to URLs being present, shouldn't be an issue for users since it'll come off the wire instead of from a file
  2. Found when re-recording cassettes (they were all expired) that our addCreditCard function was broken and not properly passing URL params. After some research, I realized the Guzzle has this supported natively and that the old urlEncode function we home-built some time ago isn't needed and could be removed

Testing

  • Updated tests to match new assertions

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team August 15, 2024 23:32
@Justintime50 Justintime50 merged commit b469f50 into master Aug 16, 2024
6 checks passed
@Justintime50 Justintime50 deleted the webhook_fixtures branch August 16, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants