Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!chore: remove createAndBuy from Batch service #321

Merged
merged 2 commits into from
Nov 28, 2023
Merged

!chore: remove createAndBuy from Batch service #321

merged 2 commits into from
Nov 28, 2023

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Nov 28, 2023 •
edited
Loading

Description

  • Removes the undocumented createAndBuy function from the Batch service. The proper usage is to create a batch first and buy it separately

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team November 28, 2023 20:57
@Justintime50 Justintime50 changed the title chore: remove createAndBuy from Batch service !chore: remove createAndBuy from Batch service Nov 28, 2023
dcaballeroc
dcaballeroc previously approved these changes Nov 28, 2023
View reviewed changes
jchen293
jchen293 previously approved these changes Nov 28, 2023
View reviewed changes
@Justintime50 Justintime50 merged commit 59bb044 into master Nov 28, 2023
6 checks passed
@Justintime50 Justintime50 deleted the remove_create_and_buy_batch branch November 28, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

@dcaballeroc dcaballeroc Awaiting requested review from dcaballeroc

@jchen293 jchen293 Awaiting requested review from jchen293

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Justintime50 @dcaballeroc @nwithan8 @jchen293