Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the unusable carbon offset params and object #319

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Nov 22, 2023

Description

EasyPost now provides Carbon Neutral shipments by default at no cost to users. This PR removes the functionality to indicate if you want to make a shipment carbon neutral as this functionality is no longer applicable.

Testing

All the cassettes had expired and a few assertions needed updating. That is done as a part of this effort

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team November 22, 2023 21:41
test/EasyPost/AddressTest.php Show resolved Hide resolved
Copy link

@dcaballeroc dcaballeroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@Justintime50 Justintime50 merged commit 5bcbc4b into master Nov 27, 2023
6 checks passed
@Justintime50 Justintime50 deleted the remove_carbon_offset branch November 27, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants