Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle scrolling#130 #204

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

thagel
Copy link
Collaborator

@thagel thagel commented Aug 23, 2024

Description

Adds a toggle to enable/disable automatic scrolling. (default enabled)
Adds custom scroll listeners, that interact with the toggle:

  • Scrolling per se disables automatic scrolling to the top
  • Scrolling to top enables automatic scrolling to the top (in other words: resets to the default)

Fixes # 130

Type of change

  • [X ] New Feature (non-breaking change to add a feature)

How to test

Please describe steps to test your change.

  • Do subscribe to #
  • Send a message to xyz with payload a
  • repeat the step before untill listview appears full
  • Send a message to xyz with payload b. validate default: message b is shown on top, others are down beneith
  • click on one of the messages with a. validate the toggle for automatic scrolling switched automatically to disabled
  • Send more messages: validate the clicked message stays on top
  • Scroll down.
  • Send more message: validate the clicked message is now on top again.
  • Scroll to the far top: validate the toggle for automatic scrolling switched automatically to enabled
  • Send another message eg. with payload c. validate the new message stays on top (default)
  • Also test behavior by actively pressing the toggle.

Checklist:

  • Code follows the coding guidelines
  • Code is understandable by others
  • Code is commented
  • Migration of local user data is included (if relevant)
  • No unexpected warnings or exceptions are thrown.
  • Plugin compatibility is checked (if relevant)
  • Unit Tests are added

Copy link

sonarcloud bot commented Aug 26, 2024

@thagel thagel requested a review from farion August 26, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant