Modification to enable ESP pump viscosity corrections #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 53 53
Lines 6082 6083 +1
=======================================
+ Hits 6080 6081 +1
Misses 2 2 |
rafacerq
changed the title
ggrbill
approved these changes
Nov 10, 2022
arthursoprana
approved these changes
Nov 10, 2022
tests/common_testing/alfasim_sdk_common_testing/filled_case_descriptions.py
Outdated
Show resolved
Hide resolved
prusse-martin
approved these changes
Nov 14, 2022
for more information, see https://pre-commit.ci
|
Kudos, SonarCloud Quality Gate passed! |
|
The issue for the linux py36 failure: actions/setup-python#544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this alfasim's PR, an enum was added to chose the ESP pump viscosity model.