flood: move the BLE load generator out to ESPresense/ble-loadgen - #10
Merged
Conversation
WalkthroughChangesBLE flooding execution and deployment
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bench/README.md`:
- Around line 13-27: Update the detached firmware-tester step configuration in
.woodpecker/hil.yml to grant CAP_NET_ADMIN via NET_ADMIN, and revise this
README’s host/setup requirements to document that capability requirement for
scripts/ble_flood.py’s HCI_CHANNEL_USER bind.
In `@scripts/ble_flood.py`:
- Around line 15-20: Update the HIL detached pipeline invocation for
ble_flood.py to use the absolute command python3 /scripts/ble_flood.py, or
explicitly add /scripts to PATH before starting it; preserve the existing
arguments and execution modes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8334484d-f0a2-4208-9779-caf285b70103
📒 Files selected for processing (4)
Dockerfilebench/README.mdbench/ble-flood.servicescripts/ble_flood.py
💤 Files with no reviewable changes (1)
- bench/ble-flood.service
The flood shares nothing with firmware-tester (no PlatformIO, no serial, no toolchain) — it's pure stdlib and a raw HCI socket. It now lives in its own repo with its own tiny image, ghcr.io/espresense/ble-loadgen, and runs as a detached step in the HIL pipeline. Remove ble_flood.py and bench/ (the host systemd service and its README) from here. The DUT-side heap-trend detection stays in hil_monitor.py — that's this repo's job.
DTTerastar
force-pushed
the
hil/flood-in-pipeline
branch
from
August 1, 2026 21:37
2d7505d to
3668b8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BLE flood shares nothing with
firmware-tester— no PlatformIO, no serial, no toolchain, just Python stdlib and a raw HCI socket. It now lives in its own repo, ESPresense/ble-loadgen, with its own tiny image (ghcr.io/espresense/ble-loadgen:1, released v1.0.0), and runs as a detached step in the HIL pipeline.What this removes
scripts/ble_flood.pybench/ble-flood.service(the host systemd unit — which was never installed, so it never actually flooded)bench/README.md(host setup for the above)What stays
scripts/hil_monitor.py— the DUT-side heap-trend detection is this repo's job and is unaffected.Companion: ESPresense/ESPresense#2432 points the HIL flood step at the new
ble-loadgen:1image. Nov1.0.xfirmware-tester tag needed for this — it only deletes files.