Skip to content

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 8, 2026

Description

Our Python 3.13 + friends environment is not solving anymore https://github.com/ESMValGroup/ESMValTool/actions/runs/20801973056/job/59748587368 but given the OSX (pure Python one) solves well, it must be something to do with friends (R, NCL, etc)


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

Comment on lines 125 to +127
- r-git2r # dependency of lintr
- r-lintr ==3.1.2
- r-styler ==1.10.3
- r-lintr
- r-styler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to get rid of those if we re-enable the pre-commit hook at

# - repo: https://github.com/lorenzwalthert/precommit/ # Checks for R
# rev: 'v0.4.2'
# hooks:
# - id: style-files # styler
# - id: lintr
# - repo: https://github.com/codespell-project/codespell
# rev: 'v2.3.0'
# hooks:
# - id: codespell

and perform the currently failing test using pre-commit instead.

We would just need to pin that pre-commit hook to the version where the checks passed (i.e. the version of the pre-commit hook that uses the versions of lintr and styler listed here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fun and games until I realized I lost you at pinning the pre-commit hook - how the heck would we know the version when that hook last passed the test? Unless you want me to write a Monte Carlo routine that loops over lintr hook versions 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not just skip the R-linting test in tests/unit/test_lint.py? I've not seen any of the following in the past 5 years:

  • anyone writing a recipe in R
  • anyone complaining that our R recipes don't follow R linting standards

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, scratch that - it's prob a good idea to have an r-lintr test, let me see what I can do with that pre-commit version, I'll toss some coins 🪙

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not forgot about this, am gonna try have a look at it tomorrow - sorry, I've been under a lot of snow elsewhere, bud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants