-
Notifications
You must be signed in to change notification settings - Fork 145
Free some dependencies to fix environment solving #4306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| - r-git2r # dependency of lintr | ||
| - r-lintr ==3.1.2 | ||
| - r-styler ==1.10.3 | ||
| - r-lintr | ||
| - r-styler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to get rid of those if we re-enable the pre-commit hook at
ESMValTool/.pre-commit-config.yaml
Lines 45 to 53 in 9bde7d3
| # - repo: https://github.com/lorenzwalthert/precommit/ # Checks for R | |
| # rev: 'v0.4.2' | |
| # hooks: | |
| # - id: style-files # styler | |
| # - id: lintr | |
| # - repo: https://github.com/codespell-project/codespell | |
| # rev: 'v2.3.0' | |
| # hooks: | |
| # - id: codespell |
and perform the currently failing test using pre-commit instead.
We would just need to pin that pre-commit hook to the version where the checks passed (i.e. the version of the pre-commit hook that uses the versions of lintr and styler listed here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all fun and games until I realized I lost you at pinning the pre-commit hook - how the heck would we know the version when that hook last passed the test? Unless you want me to write a Monte Carlo routine that loops over lintr hook versions 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not just skip the R-linting test in tests/unit/test_lint.py? I've not seen any of the following in the past 5 years:
- anyone writing a recipe in R
- anyone complaining that our R recipes don't follow R linting standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, scratch that - it's prob a good idea to have an r-lintr test, let me see what I can do with that pre-commit version, I'll toss some coins 🪙
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not forgot about this, am gonna try have a look at it tomorrow - sorry, I've been under a lot of snow elsewhere, bud
Description
Our Python 3.13 + friends environment is not solving anymore https://github.com/ESMValGroup/ESMValTool/actions/runs/20801973056/job/59748587368 but given the OSX (pure Python one) solves well, it must be something to do with friends (R, NCL, etc)
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.