Skip to content

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented May 23, 2025

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The psyplot diagnostic also has an api page that should still be removed from the doc. I'd also not add a legacy recipe to the broken recipe list.

@valeriupredoi
Copy link
Contributor Author

cheers @bettina-gier - API removals in 504737d 6b51eda and 0714fe4

@valeriupredoi valeriupredoi requested a review from katjaweigel May 23, 2025 11:54
@valeriupredoi valeriupredoi added this to the v2.13.0 milestone May 23, 2025
Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, and nice catching the FAQ paragraph

@valeriupredoi
Copy link
Contributor Author

looks good now, and nice catching the FAQ paragraph

many thanks @bettina-gier 🍺 Since this all was done by @schlunma (sorry buds!) could I get a nod from him as well, please, and from @katjaweigel since she mentioned she kinds needs the psy diag 🍺

@schlunma
Copy link
Contributor

Thanks V!

2 points:

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented May 23, 2025

thanks, Manu 🍺 API ref removed in 3af5325 - I'll open a PR in Core to remove that, on Monday, pub time now 🍻

@schlunma EDIT: Tuesday, since I had forgotten we have Monday off, but here is the Core PR (thanks for pointing me to that ref!) ESMValGroup/ESMValCore#2741

Copy link
Contributor

@katjaweigel katjaweigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valeriupredoi !
My first thought was, that it would be better to have a replacement first, but Tina reminded me, that it is not working any more already now with up to date python, so it is probably better to remove it.

@valeriupredoi
Copy link
Contributor Author

Thanks @valeriupredoi ! My first thought was, that it would be better to have a replacement first, but Tina reminded me, that it is not working any more already now with up to date python, so it is probably better to remove it.

hi @katjaweigel sorry we had a bank holiday in the UK yesterday; indeed, the psy packages always need to be updated manually, and that was fine before Python 3.13, and, in fact, also to answer @bouweandela , I am a maintainer of some of them on conda-feedstock, so I tried to help as much as possible; unfortunately, the situation now is that the packages suffer not from a technical problem, but rather, from a functional (scientific) issue, that Phillipp had struggled to fix, and I have no clue what the actual problem is, since he does his testing on an Azure platform that I don't have access to, so things are a bit trickier than a simple issue with maintenance.

I will merge this one now, and make the Python 3.13 PR ready, but will also try and see if we can replace this recipe with one that uses more easily to maintain dependencies, I promise. Cheers, and very sorry for the inconvenience 🍺

@valeriupredoi
Copy link
Contributor Author

sad to see this going but happy to have us back on the modern env path 🍺

@valeriupredoi valeriupredoi merged commit 686c6ae into main May 27, 2025
8 checks passed
@valeriupredoi valeriupredoi deleted the retire_psyplot branch May 27, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retire recipe_psyplot.yml together with its diagnostic psyplot_diag.py

5 participants