-
Notifications
You must be signed in to change notification settings - Fork 145
Retire psyplot recipe and diagnostic #4063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bettina-gier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The psyplot diagnostic also has an api page that should still be removed from the doc. I'd also not add a legacy recipe to the broken recipe list.
|
cheers @bettina-gier - API removals in 504737d 6b51eda and 0714fe4 |
Co-authored-by: Bettina Gier <[email protected]>
bettina-gier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now, and nice catching the FAQ paragraph
many thanks @bettina-gier 🍺 Since this all was done by @schlunma (sorry buds!) could I get a nod from him as well, please, and from @katjaweigel since she mentioned she kinds needs the psy diag 🍺 |
|
Thanks V! 2 points:
|
|
thanks, Manu 🍺 API ref removed in 3af5325 - I'll open a PR in Core to remove that, on Monday, pub time now 🍻 @schlunma EDIT: Tuesday, since I had forgotten we have Monday off, but here is the Core PR (thanks for pointing me to that ref!) ESMValGroup/ESMValCore#2741 |
katjaweigel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @valeriupredoi !
My first thought was, that it would be better to have a replacement first, but Tina reminded me, that it is not working any more already now with up to date python, so it is probably better to remove it.
hi @katjaweigel sorry we had a bank holiday in the UK yesterday; indeed, the psy packages always need to be updated manually, and that was fine before Python 3.13, and, in fact, also to answer @bouweandela , I am a maintainer of some of them on conda-feedstock, so I tried to help as much as possible; unfortunately, the situation now is that the packages suffer not from a technical problem, but rather, from a functional (scientific) issue, that Phillipp had struggled to fix, and I have no clue what the actual problem is, since he does his testing on an Azure platform that I don't have access to, so things are a bit trickier than a simple issue with maintenance. I will merge this one now, and make the Python 3.13 PR ready, but will also try and see if we can replace this recipe with one that uses more easily to maintain dependencies, I promise. Cheers, and very sorry for the inconvenience 🍺 |
|
sad to see this going but happy to have us back on the modern env path 🍺 |
Description
recipe_psyplot.ymltogether with its diagnosticpsyplot_diag.py#4062esmvaltool install Julia) and add docs how to install from source #3921 will immediately release full functionality for Support Python 3.13 #3805Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.