Unpin flake8 #2937
Merged
Unpin flake8 #2937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlunma
approved these changes
Nov 22, 2022
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @valeriupredoi !
Contributor
Author
|
yay thanks, Manu! Any of @ESMValGroup/technical-lead-development-team got 2sec merge this please? 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
flake8can now be free 🐳 since the pin used to be there so that the specific version works with thepytest-flake8plugin, but we don't use that no more. We did the same in Core ESMValGroup/ESMValCore#1820Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.