suppress installing and reinstalling deps with pip at readthedocs builds #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
Author
|
BTW if anyone is interested in discussion this more with the Readthedocs folk, I opened an issue there readthedocs/readthedocs.org#9727 |
bouweandela
requested changes
Nov 10, 2022
Member
bouweandela
left a comment
bouweandela
left a comment
There was a problem hiding this comment.
Great find @valeriupredoi, I didn't know this was possible!
Co-authored-by: Bouwe Andela <[email protected]>
Contributor
Author
cheers, bud! Pretty nifty option, and well buried in their documentation 🐶 |
bouweandela
approved these changes
Nov 11, 2022
Contributor
Author
|
thanks a lot for looking and reviewing @bouweandela 🍺 Can any of the @ESMValGroup/technical-lead-development-team please have a quick look and merge? 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readthedocs builds use
pip install --upgrade --upgrade-strategy eagerto install and eventually reinstall everything from the env via pip - this is discussed in readthedocs/readthedocs.org#8890 and is not something good for many reasons, one of them, and a very recent and pertinent one is that the build will chuck a wobbly if the package versions differ from conda-forge to pypi. I am trying to fix this here via the readthedocs build conf file.EDIT by some miracle I found the magic incantation to get this done, and supported by the Readthedocs API too - @bouweandela do you recommend using
pip install -e .[doc]instead ofpip install -e .[develop]?Docs built with this PR: https://esmvaltool--2913.org.readthedocs.build/en/2913/
Closes #2903 once and for all