Removed custom version of AtmosphereSigmaFactory in diagnostics

[schlunma]

Description

This PR removes the custom version of AtmosphereSigmaFactory in all affected diagnostics.

Corresponding PR in the core: ESMValGroup/ESMValCore#1382

• Related to Iris module error when running recipe_ecs_constraints.yml ESMValCore#1380 and Prepare release 2.4.0 #2354

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully
• 🧪 Recipe is well documented
• 🧪 Figure(s) and data look as expected from literature
• 🛠 Provenance information has been added

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[valeriupredoi]

cheers @schlunma 👍

[valeriupredoi]

@esmvalbot please run recipe_ecs_constraints.yml

[esmvalbot]

Since @valeriupredoi asked, ESMValBot will run recipe recipe_ecs_constraints.yml as soon as possible, output will be generated here

[schlunma]

@esmvalbot please run recipe_ecs_constraints.yml

Does the bot use the current main of ESMValCore? If not this will fail 😬

[valeriupredoi]

sure it will, but I thought this bit of the diag will go through? Ignore the run if I'm wrong

[remi-kazeroni]

@esmvalbot please run recipe_ecs_constraints.yml

Does the bot use the current main of ESMValCore? If not this will fail 😬

Yes it does. The bot does not install the Core in dev mode, just the Tool. Let's wait for the outcome of this run before merging this.

[schlunma]

It needs the changes in the core (in particular the changed fixes for some models) to work, so it will only work with the current main of ESMValCore. I tested the recipes recipe_ecs_constraints.yml and recipe_schlund20esd.yml locally, both run fine now! 🎉

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_ecs_constraints.yml: exit is 1, output has been generated here

[valeriupredoi]

well the bot pulled a fast one and surprised us by not finding data - not even close to running the diagnostic 😆 Merge at will by me 👍

[remi-kazeroni]

In my previous attempt to run this recipe (see #1380), the same file was missing and automatically downloaded. For reference, the automatic download option has not yet been enabled for the bot due to a lack of disk space on that VM.

[valeriupredoi]

cheers @remi-kazeroni - safer that way 😁