Skip to content

Conversation

@axel-lauer
Copy link
Contributor

Added new ESMValTool logo (as pdf and png) and updated doc/sphinx/source/conf.py accordingly. At the moment, the old "legacy" logo is also still present but not used.

@valeriupredoi
Copy link
Contributor

do you think it'd be good to add a license/copyright to the figure? It is your/our creation after all

@valeriupredoi
Copy link
Contributor

@axel-lauer
Copy link
Contributor Author

do you think it'd be good to add a license/copyright to the figure? It is your/our creation after all

So far, I thought since the ESMValTool is released under the Apache License, Version 2.0, this would automatically also cover things such as the logo or documentation. I also thought that the copyrights listed in https://github.com/ESMValGroup/ESMValTool/blob/master/NOTICE should apply to the whole package, but I might be wrong. Does anyone know if that's the case?

@axel-lauer
Copy link
Contributor Author

note that the logo doesn't show in README, https://github.com/ESMValGroup/ESMValTool/blob/master/doc/sphinx/source/figures/ESMValTool-logo-2.png gives a 404

I kind of presumed this would be automatically resolved once the branch is merged into master. If not, I would appreciate some help with this.

@valeriupredoi
Copy link
Contributor

valeriupredoi commented May 11, 2021

do you think it'd be good to add a license/copyright to the figure? It is your/our creation after all

So far, I thought since the ESMValTool is released under the Apache License, Version 2.0, this would automatically also cover things such as the logo or documentation. I also thought that the copyrights listed in https://github.com/ESMValGroup/ESMValTool/blob/master/NOTICE should apply to the whole package, but I might be wrong. Does anyone know if that's the case?

Logos are a bit special - the licenses they go under are more restrictive than creative commons - here's an explanation - now, do we want to go the long way and license it?

@valeriupredoi
Copy link
Contributor

note that the logo doesn't show in README, https://github.com/ESMValGroup/ESMValTool/blob/master/doc/sphinx/source/figures/ESMValTool-logo-2.png gives a 404

I kind of presumed this would be automatically resolved once the branch is merged into master. If not, I would appreciate some help with this.

yes, but I wanted to see it how it looks in the README before the merge, here, it looks terrific, love it 😍

newLogoinREADME

@valeriupredoi
Copy link
Contributor

well, apart from the eyesore that the FAILED CI test is 🤣

@valeriupredoi valeriupredoi self-requested a review May 11, 2021 17:43
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the new logo! but before we merge we need to think about the license thingie

@axel-lauer axel-lauer merged commit e36a9ea into main Jun 8, 2021
@axel-lauer axel-lauer deleted the logo_update branch June 8, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants