Skip to content

Conversation

@Peter9192
Copy link
Contributor

@Peter9192 Peter9192 commented Mar 4, 2021

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic:


To help with the number pull requests:

@Peter9192
Copy link
Contributor Author

@esmvalbot Please run recipe_impact.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 10, 2021

Since @Peter9192 asked, ESMValBot will run recipe recipe_impact.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 10, 2021

ESMValBot is sorry to report it failed to run recipe recipe_impact.yml: exit is 1, output has been generated here

@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 10, 2021
@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 10, 2021
@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 10, 2021
@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 10, 2021
@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 10, 2021
@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 10, 2021
@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 10, 2021
@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 10, 2021
@Peter9192
Copy link
Contributor Author

@esmvalbot Please run recipe_impact.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 10, 2021

Since @Peter9192 asked, ESMValBot will run recipe recipe_impact.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 10, 2021

ESMValBot is sorry to report it failed to run recipe recipe_impact.yml: exit is 1, output has been generated here

@Peter9192
Copy link
Contributor Author

Why is the bot not working... 😕

@nielsdrost
Copy link
Member

@Peter9192 Sorry, the bot machine ran out of disk space :-(

See here for the output: https://esmvaltool.cloud.dkrz.de/shared/esmvaltool/esmvalbot-output/impact-recipe-km3lft58_3/

It seems there are some input files missing.

@Peter9192
Copy link
Contributor Author

@esmvalbot Please run recipe_impact.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 12, 2021

Since @Peter9192 asked, ESMValBot will run recipe recipe_impact.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 12, 2021

ESMValBot is happy to report recipe recipe_impact.yml ran OK, output has been generated here

@Peter9192
Copy link
Contributor Author

@esmvalbot Please run recipe_impact.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 16, 2021

Since @Peter9192 asked, ESMValBot will run recipe recipe_impact.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 16, 2021

ESMValBot is sorry to report it failed to run recipe recipe_impact.yml: exit is 1, output has been generated here

@Peter9192
Copy link
Contributor Author

@esmvalbot Please run recipe_impact.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 17, 2021

Since @Peter9192 asked, ESMValBot will run recipe recipe_impact.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 17, 2021

ESMValBot is happy to report recipe recipe_impact.yml ran OK, output has been generated here

@Peter9192 Peter9192 requested a review from stefsmeets March 17, 2021 13:18
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me! 🚀

@stefsmeets stefsmeets mentioned this pull request Mar 23, 2021
@Peter9192
Copy link
Contributor Author

@esmvalbot Please run recipe_impact.yml

@esmvalbot
Copy link

esmvalbot bot commented Apr 15, 2021

Since @Peter9192 asked, ESMValBot will run recipe recipe_impact.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Apr 15, 2021

ESMValBot is happy to report recipe recipe_impact.yml ran OK, output has been generated here

@Peter9192
Copy link
Contributor Author

@nielsdrost as discussed, ready for your approval 😃

@nielsdrost nielsdrost self-requested a review April 30, 2021 12:30
Copy link
Member

@nielsdrost nielsdrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Peter9192. Adding this scientific review on behalf of the KNMI scientist we went over this recipe with.

@nielsdrost nielsdrost merged commit b1f9720 into master Apr 30, 2021
@nielsdrost nielsdrost deleted the impact-recipe branch April 30, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New recipe for climate impact metrics

5 participants