Skip to content

Fix flake8 tests on CircleCI #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouweandela merged 7 commits into from
Mar 12, 2021
Merged

Fix flake8 tests on CircleCI #2070

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4092096
Test that a flake8 issue is found
bouweandela Mar 4, 2021
2fdf8f6
an abhorrent code issue that should be the mother of all fails
valeriupredoi Mar 8, 2021
882bd72
another flake trap
valeriupredoi Mar 8, 2021
c5fb36d
repositioned flake8 flag
valeriupredoi Mar 8, 2021
c736c0f
Try if this helps
bouweandela Mar 10, 2021
59488cb
Move --flake8 option back
bouweandela Mar 10, 2021
ccb1067
Fix flake8 issue
bouweandela Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,14 @@ jobs:
python --version > /logs/python_version.txt
conda env export > /logs/environment.yml
pip install .[test] > /logs/install.txt
# Run flake8 check with source code (it doesn't work without it)
pytest -n 2 -m flake8
# Update/install Julia and R dependencies
esmvaltool install Julia > /logs/install_Julia.txt
esmvaltool install R > /logs/install_R.txt
# Remove source to test installed software
rm -r esmvaltool
pytest -n 2
pytest -n 2 -m 'not flake8'
- store_artifacts:
path: /logs
- store_artifacts:
Expand Down