-
Notifications
You must be signed in to change notification settings - Fork 49
Implement three levels of CMOR checks strictness #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 57 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
547c9c5
ported Javi's functionality from dry checks to mainstream to be used …
valeriupredoi b693bc0
started work, committing quickly, laptop seems to be dying soon
valeriupredoi 861a91c
talk to the Check
valeriupredoi b5b96b1
communication with the cmor checker
valeriupredoi 9a6b264
implemented tiered errors
valeriupredoi a5b7680
rephrased a bit the error messages
valeriupredoi 15919a7
Bouwe suggestion
valeriupredoi edd1f94
Bouwe suggestion
valeriupredoi 0cabd66
replaced config key
valeriupredoi 1c4701c
added default opt to cmd line
valeriupredoi 30eee1d
fixed tests
valeriupredoi e71b6dc
fixed missing func arg
valeriupredoi 694411b
fixed opt retrieval
valeriupredoi b1dfb51
Do not report anything in fix_metadata step
sloosvel bb70373
Relax some check_metadata checks
sloosvel 3dee4ae
putting command line args dependent options in fix
valeriupredoi c7d75a3
making the implementation actually work
valeriupredoi 847e8f1
adding func args
valeriupredoi c7971a5
fixed lines too long
valeriupredoi 23e14de
fixed recipe tests
valeriupredoi 0f9479d
fixed call to fix test
valeriupredoi f59418e
removed debug messgae
valeriupredoi f4ac790
Merge branch 'development' into cmor_checks_tiers
valeriupredoi bd9b4c9
Remove condition for regular errors
sloosvel 4f6b6a4
Add unit tests
sloosvel 06410b2
fixed linter
valeriupredoi 57dd77b
fixed rank check
valeriupredoi 3e27e49
Relax check on presence of some coordinates
sloosvel 8f2e8dc
Fix style issues
sloosvel 84ded5a
Add support for diferent error levels in checker
6addf1f
Remove unused import
c55a1ed
Fix codacy issues
ecc1062
fixed func attr
valeriupredoi aa48d92
fixed mock test
valeriupredoi 70f64ce
proper fixed attr case is string
valeriupredoi f8584ce
fixed typo in func name
valeriupredoi a5885da
add time aux coords only if time in coords
valeriupredoi 10ff62c
Clean a bit
d7d0561
added documentation on check levels
valeriupredoi 9cbd895
added more meat to the check levels doc
valeriupredoi b9375aa
Doc update
dfb1e34
Rename check levels, keep only one ignore option
sloosvel 2237941
Remove debug file
sloosvel 7f04bae
Update documentation with name changes
sloosvel 8c8b05c
Report warnings when converting units
sloosvel df2c681
Update doc/esmvalcore/fixing_data.rst
sloosvel 8f33f02
Merge branch 'master' of https://github.com/ESMValGroup/ESMValCore in…
e27617c
Update docstrings
sloosvel 9bcbf21
Merge branch 'master' into cmor_checks_tiers
sloosvel b218fb1
Attemp to fix conflicts
sloosvel 1f45441
Update esmvalcore/cmor/check.py
sloosvel 24c4cad
Update esmvalcore/cmor/check.py
sloosvel c0f4556
Update esmvalcore/cmor/check.py
sloosvel c3315a8
Update esmvalcore/cmor/check.py
sloosvel 913e9b0
Update esmvalcore/cmor/fix.py
sloosvel 8f83249
Update esmvalcore/cmor/fix.py
sloosvel 91a205e
Update esmvalcore/cmor/check.py
sloosvel 4e102d0
Apply suggestions from code review
sloosvel e0d9340
Improve warning message
sloosvel 56ce2c2
Report missing coordinates with levels as critical
sloosvel 1d5a0eb
Improve docstring
sloosvel 87f34b8
Merge remote-tracking branch 'origin/master' into cmor_checks_tiers
sloosvel 4c96139
Fix identation
sloosvel 275d65c
Fix tests
sloosvel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.