Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 20, 2025

Description

This fixes the issue for esmvalcore.local.LocalDataSource. and esmvalcore.esgf.ESGFDataSources, but not for esmvalcore.io.intake_esgf.IntakeESGFDataSources.

Closes #2906


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.55%. Comparing base (d34b25c) to head (97f2422).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2900      +/-   ##
==========================================
- Coverage   95.55%   95.55%   -0.01%     
==========================================
  Files         263      263              
  Lines       15508    15506       -2     
==========================================
- Hits        14819    14817       -2     
  Misses        689      689              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela force-pushed the fix-timerange-wildcards branch from 002b80e to d7f02ed Compare November 24, 2025 10:21
@bouweandela bouweandela added the enhancement New feature or request label Nov 24, 2025
@bouweandela bouweandela changed the title Fix timerange wildcards Fix issue with wildcards in timerange after introducing data sources Nov 24, 2025
@bouweandela bouweandela force-pushed the fix-timerange-wildcards branch from d7f02ed to 58c0209 Compare November 24, 2025 10:36
@bouweandela bouweandela marked this pull request as ready for review November 24, 2025 10:58
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks! A small suggestion for the test, please 🍺

@valeriupredoi
Copy link
Contributor

also I believe this closes #2908 as well?

@bouweandela
Copy link
Member Author

also I believe this closes #2908 as well?

Unfortunately not: wildcard expansion relies on the data source being able to provide the facet values and currently intake-esgf does not provide enough information to add a timerange facet in esmvalcore.io.intake_esgf.

@bouweandela bouweandela merged commit 6a2aae7 into main Nov 26, 2025
4 checks passed
@bouweandela bouweandela deleted the fix-timerange-wildcards branch November 26, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wildcards in timerange no longer work

3 participants