-
Notifications
You must be signed in to change notification settings - Fork 44
Fix issue with wildcards in timerange after introducing data sources #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2900 +/- ##
==========================================
- Coverage 95.55% 95.55% -0.01%
==========================================
Files 263 263
Lines 15508 15506 -2
==========================================
- Hits 14819 14817 -2
Misses 689 689 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
002b80e to
d7f02ed
Compare
d7f02ed to
58c0209
Compare
valeriupredoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks! A small suggestion for the test, please 🍺
|
also I believe this closes #2908 as well? |
Unfortunately not: wildcard expansion relies on the data source being able to provide the facet values and currently intake-esgf does not provide enough information to add a |
Description
This fixes the issue for
esmvalcore.local.LocalDataSource. andesmvalcore.esgf.ESGFDataSources, but not foresmvalcore.io.intake_esgf.IntakeESGFDataSources.Closes #2906
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: