Skip to content

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Aug 1, 2025

Description

This PR aligns our custom lwp table with the CMIP6 version.

See #2789 (review).

Backwards-incompatible change #

This PR also changes standard name of lwp in our custom table from "" to "atmosphere_mass_content_of_cloud_liquid_water", which will be a problem with downstream code that depends on the standard_name entry. I won't expect any problems with this to be honest.

There is no way to restore the old behavior. Downstream code needs to be adapted.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.13.0 milestone Aug 1, 2025
@schlunma schlunma requested a review from axel-lauer August 1, 2025 08:44
@schlunma schlunma added cmor Related to the CMOR standard backwards incompatible change labels Aug 1, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.45%. Comparing base (976cfec) to head (6352870).
⚠️ Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2791   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files         260      260           
  Lines       15496    15496           
=======================================
  Hits        14792    14792           
  Misses        704      704           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@axel-lauer axel-lauer mentioned this pull request Aug 1, 2025
10 tasks
Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and solves a problem with multi_model_statistics that prevented using datasets that provide lwp directly and datasets that require derivation of lwp.

@schlunma
Copy link
Contributor Author

schlunma commented Aug 1, 2025

@ESMValGroup/esmvaltool-coreteam This introduces a (small) backwards-incompatible change. However, I don't expect any problems with this.

Please object if you have any concerns about this.

This will be merged in 2 weeks.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good by me, putting a temporary blocker to allow for the two weeks and avoid eager merges; I put "Merge PR 2791" in me agenda, so I won't forget 😁

@valeriupredoi
Copy link
Contributor

this will be merged this week, Friday 15th 🍺 @ESMValGroup/esmvaltool-coreteam please see #2791 (comment) and comment here as per your one and a half pennies (British two cents 😁 )

@valeriupredoi
Copy link
Contributor

time's up! I'm merging this 🚚

@valeriupredoi valeriupredoi merged commit 357b8bd into main Aug 15, 2025
8 checks passed
@valeriupredoi valeriupredoi deleted the align_custom_lwp_entry branch August 15, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards incompatible change cmor Related to the CMOR standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants