Skip to content

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Jan 24, 2025

Description

Since #1808, it is possible to use the multi-model statistics preprocessor on data with arbitrary dimensions (i.e., also on data without a time dimension). Thus, it should be possible to use it on data without a timerange, too.

This PR implements that.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the preprocessor Related to the preprocessor label Jan 24, 2025
@schlunma schlunma added this to the v2.12.0 milestone Jan 24, 2025
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (e415269) to head (7f9f33a).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2644   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         255      255           
  Lines       14880    14885    +5     
=======================================
+ Hits        14146    14151    +5     
  Misses        734      734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! One thing I am a bit confused by is how did the testing for the case of a dataset without time axis was done before this PR, if that dataset would not have a timerange attribute

@valeriupredoi
Copy link
Contributor

nvmd, I unconfused myself - there wasn't much of that 😁

@sloosvel sloosvel merged commit e3eb9ff into main Feb 4, 2025
7 checks passed
@sloosvel sloosvel deleted the multi_model_stats_without_timerange branch February 4, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preprocessor Related to the preprocessor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants