Avoid loading entire files into memory when downloading from ESGF #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 246 246
Lines 14023 14024 +1
=======================================
+ Hits 13254 13255 +1
Misses 769 769 ☔ View full report in Codecov by Sentry. |
valeriupredoi
approved these changes
May 24, 2024
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
Very useful, thanks a lot @bouweandela 🍺
Member
Author
|
@chrisbillowsMO if it is still possible, this bugfix would also be nice to have in the release. |
Contributor
@bouweandela Shouldn't be a problem. Have added to our checklist. |
Contributor
|
Many thanks @chrisbillowsMO - merge at will 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to psf/requests#5536, downloading files from ESGF loaded entire files into memory, leading to potentially high memory use when downloading large files. This pull request avoids the issue.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
projects/ESMValCore/en/latest/contributing.html#dependencies) correctly
To help with the number pull requests: