Skip to content

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented May 10, 2024

Description

We should pin numpy <2 for the release - David Hassell pulled the rc1 in the cfpython env, here's what I wrote to him this is the bug in pip that makes possible a pre package get pulled in pypa/pip#7579 and real world case for the same issue you had here Unidata/cftime#327 - slim chances for us to hit this bug, since all's been fine so far, but better err on the safe side!

@ehogan @chrisbillowsMO I think it'd be safe to include this in the release, maybe just after ESMValCore rc1, so it doesn't mess with your current procedures. Once numpy=2 stable is out, and we've fixed all the wiggles (ours or not) via #2395 then we can unpin. Cheers 🍺


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added the installation Installation problem label May 10, 2024
@valeriupredoi valeriupredoi added this to the v2.11.0 milestone May 10, 2024
@codecov
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (a782af8) to head (fc269ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2415   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         246      246           
  Lines       14020    14020           
=======================================
  Hits        13251    13251           
  Misses        769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi
Copy link
Contributor Author

cheers @bouweandela 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

installation Installation problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants